From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#50689: 28.0.50; Wrong VC repo URL detection in bug-reference-mode Date: Mon, 20 Sep 2021 08:45:18 +0200 Message-ID: <87ee9jpvlz.fsf@gnu.org> References: <877dfcb08k.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16016"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.6.6; emacs 28.0.50 Cc: 50689@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 20 09:15:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSDWF-0003xd-Pc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 09:15:15 +0200 Original-Received: from localhost ([::1]:37838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSDWE-0003ip-GA for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 03:15:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSDW3-0003gI-2p for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 03:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57562) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSDW2-0007wb-Pw for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 03:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSDW2-0002Z0-EE for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 03:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Sep 2021 07:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50689 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50689-submit@debbugs.gnu.org id=B50689.16321220569781 (code B ref 50689); Mon, 20 Sep 2021 07:15:02 +0000 Original-Received: (at 50689) by debbugs.gnu.org; 20 Sep 2021 07:14:16 +0000 Original-Received: from localhost ([127.0.0.1]:40875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSDVI-0002Xg-0H for submit@debbugs.gnu.org; Mon, 20 Sep 2021 03:14:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSDVF-0002XU-VS for 50689@debbugs.gnu.org; Mon, 20 Sep 2021 03:14:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51706) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSDV8-00079f-Lj; Mon, 20 Sep 2021 03:14:07 -0400 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:49073) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSDV8-0007oD-8Q; Mon, 20 Sep 2021 03:14:06 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 3C69F27C0054; Mon, 20 Sep 2021 03:14:05 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 20 Sep 2021 03:14:05 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeiuddgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe dvhfduveeuvddtveeifeefhedvffeugeehjedtfffhieevledvgfehueejgfehffenucff ohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhn rghlihhthidqkeeijeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrgh esfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Sep 2021 03:14:04 -0400 (EDT) In-reply-to: <877dfcb08k.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214837 Archived-At: "Basil L. Contovounesios" writes: Hey Basil, > Tags: patch > > In a clone of https://github.com/abo-abo/swiper.git, with the following > remotes: > > $ git remote -v > elpa savannah:/srv/git/emacs/elpa.git (fetch) > elpa savannah:/srv/git/emacs/elpa.git (push) > origin git@github.com:basil-conto/swiper.git (fetch) > origin git@github.com:basil-conto/swiper.git (push) > upstream git@github.com:abo-abo/swiper.git (fetch) > upstream git@github.com:abo-abo/swiper.git (push) > > 0. emacs -Q ivy.el > 1. M-: (vc-call-backend 'Git 'repository-url "upstream") RET > > This returns: "git@github.com:basil-conto/swiper.git" > instead of: "git@github.com:abo-abo/swiper.git" > > Step 1 is effectively what bug-reference-try-setup-from-vc does, and I > believe the incorrect result is due to vc-git-repository-url expecting > a file name, not a Git remote name, as its first argument. Oh, good catch! BTW, I've thought I've checked that previously /issues/X redirected you to /issues/X but that doesn't seem to be the case right anymore... > How's the attached fix? LGTM. Not sure about when-let/seq-fns. I refrained from using them in bug-reference.el so that it doesn't require subr-x.el and seq.el. But OTHO, I very much like them and would happily use them once they are loaded anyway. Bye, Tassilo