bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Jai Flack via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-An-mu-backend-for-gnus-search.patch --]
[-- Type: text/x-diff, Size: 8086 bytes --]

From 15214b484ab11bdac59644e9fa937d2af4e9f587 Mon Sep 17 00:00:00 2001
From: Jai Flack <jflack@disroot.org>
Date: Fri, 1 Apr 2022 11:13:11 +1000
Subject: [PATCH] An mu backend for gnus-search

* lisp/gnus-search.el (gnus-search-mu-program): New defcustom
(gnus-search-mu-switches): New defcustom
(gnus-search-mu-remove-prefix): New defcustom
(gnus-search-mu-config-directory): New defcustom
(gnus-search-mu-raw-queries-p): New defcustom
(gnus-search-mu): New subclass of gnus-search-indexed
(gnus-search-transform-expression): New method
(gnus-search-mu-handle-date): New function
(gnus-search-mu-handle-flag): New function
(gnus-search-indexed-extract): New method
(gnus-search-indexed-search-command): New method
---
 doc/misc/gnus.texi       |   9 ++-
 etc/NEWS                 |   5 ++
 lisp/gnus/gnus-search.el | 143 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 154 insertions(+), 3 deletions(-)

diff --git a/doc/misc/gnus.texi b/doc/misc/gnus.texi
index eb93269721..9faace1a75 100644
--- a/doc/misc/gnus.texi
+++ b/doc/misc/gnus.texi
@@ -21651,6 +21651,9 @@ Search Engines
 
 @item
 @code{gnus-search-namazu}
+
+@item
+@code{gnus-search-mu}
 @end itemize
 
 If you need more granularity, you can specify a search engine in the
@@ -21665,7 +21668,7 @@ Search Engines
      (config-file "/home/user/.mail/.notmuch_config")))
 @end example
 
-Search engines like notmuch, namazu and mairix are similar in
+Search engines like notmuch, namazu, mairix and mu are similar in
 behavior: they use a local executable to create an index of a message
 store, and run command line search queries against those messages,
 and return a list of absolute file names of matching messages.
@@ -21704,8 +21707,8 @@ Search Engines
 non-standard notmuch program, you might set
 @code{gnus-search-notmuch-program} to @file{/usr/local/bin/notmuch}.
 This would apply to all notmuch engines.  The engines that use these
-options are: ``notmuch'', ``namazu'', ``mairix'', ``swish-e'' and
-``swish++''.
+options are: ``notmuch'', ``namazu'', ``mairix'', ``mu'', ``swish-e''
+and ``swish++''.
 
 Alternately, the options can be set directly on your Gnus server
 definitions, for instance, in the @code{nnmaildir} example above.
diff --git a/etc/NEWS b/etc/NEWS
index aaab0f4517..7f65d24378 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -786,6 +786,11 @@ displayed as emojis.  Default nil.
 This is bound to 'W D e' and will display symbols that have emoji
 representation as emojis.
 
++++
+*** New mu backend for gnus-search.
+Configuration is very similar to the notmuch and namazu backends. It supports
+the unified search syntax.
+
 ** EIEIO
 
 +++
diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el
index 4ca873eeec..a7150b7652 100644
--- a/lisp/gnus/gnus-search.el
+++ b/lisp/gnus/gnus-search.el
@@ -349,6 +349,42 @@ gnus-search-mairix-raw-queries-p
   :version "28.1"
   :type 'boolean)
 
+(defcustom gnus-search-mu-program "mu"
+  "Name of mu search executable.
+This can also be set per-server."
+  :version "29.1"
+  :type '(string))
+
+(defcustom gnus-search-mu-switches '()
+  "A list of strings, to be given as additional arguments to mu.
+Note that this should be a list. I.e., do NOT use the following:
+    (setq gnus-search-mu-switches \"-u -r\")
+Instead, use this:
+    (setq gnus-search-mu-switches \\='(\"-u\" \"-r\"))
+This can also be set per-server."
+  :version "29.1"
+  :type '(repeat (string)))
+
+(defcustom gnus-search-mu-remove-prefix (expand-file-name "Mail/" "~")
+  "A prefix to remove from the mu results to get a group name.
+Usually this will be set to the path to your mail directory. This
+can also be set per-server."
+  :version "29.1"
+  :type '(directory))
+
+(defcustom gnus-search-mu-config-directory
+  (expand-file-name "~/.cache/mu")
+  "Configuration directory for mu.
+This can also be set per-server."
+  :version "29.1"
+  :type 'file)
+
+(defcustom gnus-search-mu-raw-queries-p nil
+  "If t, all mu engines will only accept raw search query strings.
+This can also be set per-server."
+  :version "29.1"
+  :type 'boolean)
+
 ;; Options for search language parsing.
 
 (defcustom gnus-search-expandable-keys
@@ -903,6 +939,18 @@ gnus-search-notmuch
    (raw-queries-p
     :initform (symbol-value 'gnus-search-notmuch-raw-queries-p))))
 
+(defclass gnus-search-mu (gnus-search-indexed)
+  ((program
+    :initform (symbol-value 'gnus-search-mu-program))
+   (remove-prefix
+    :initform (symbol-value 'gnus-search-mu-remove-prefix))
+   (switches
+    :initform (symbol-value 'gnus-search-mu-switches))
+   (config-directory
+    :initform (symbol-value 'gnus-search-mu-config-directory))
+   (raw-queries-p
+    :initform (symbol-value 'gnus-search-mu-raw-queries-p))))
+
 (define-obsolete-variable-alias 'nnir-method-default-engines
   'gnus-search-default-engines "28.1")
 
@@ -1849,6 +1897,101 @@ gnus-search-indexed-search-command
 	   (when (alist-get 'thread query) (list "-t"))
 	   (list qstring))))
 
+;;; Mu interface
+
+(cl-defmethod gnus-search-transform-expression ((engine gnus-search-mu)
+						(expr list))
+  (cl-case (car expr)
+    (recipient (setf (car expr) 'recip))
+    (address (setf (car expr) 'contact))
+    (id (setf (car expr) 'msgid))
+    (attachment (setf (car expr) 'file)))
+  (cl-flet ()
+    (cond
+     ((consp (car expr))
+      (format "(%s)" (gnus-search-transform engine expr)))
+     ;; Explicitly leave out 'date as gnus-search will encode it
+     ;; first; it is handled later
+     ((memq (car expr) '(cc c bcc h from f to t subject s body b
+			    maildir m msgid i prio p flag g d
+			    size z embed e file j mime y tag x
+			    list v))
+      (format "%s:%s" (car expr)
+	      (if (string-match "\\`\\*" (cdr expr))
+		  (replace-match "" nil nil (cdr expr))
+		(cdr expr))))
+     ((eq (car expr) 'mark)
+      (format "flag:%s" (gnus-search-mu-handle-flag (cdr expr))))
+     ((eq (car expr) 'date)
+      (format "date:%s" (gnus-search-mu-handle-date (cdr expr))))
+     ((eq (car expr) 'before)
+      (format "date:..%s" (gnus-search-mu-handle-date (cdr expr))))
+     ((eq (car expr) 'since)
+      (format "date:%s.." (gnus-search-mu-handle-date (cdr expr))))
+     (t (ignore-errors (cl-call-next-method))))))
+
+(defun gnus-search-mu-handle-date (date)
+  (if (stringp date)
+      date
+    (pcase date
+      (`(nil ,m nil)
+       (nth (1- m) gnus-english-month-names))
+      (`(nil nil ,y)
+       (number-to-string y))
+      ;; mu prefers ISO date YYYY-MM-DD HH:MM:SS
+      (`(,d ,m nil)
+       (let* ((ct (decode-time))
+	      (cm (decoded-time-month ct))
+	      (cy (decoded-time-year ct))
+	      (y (if (> cm m)
+		     cy
+		   (1- cy))))
+	 (format "%d-%02d-%02d" y m d)))
+      (`(nil ,m ,y)
+       (format "%d-%02d" y m))
+      (`(,d ,m ,y)
+       (format "%d-%02d-%02d" y m d)))))
+
+(defun gnus-search-mu-handle-flag (flag)
+  ;; Only change what doesn't match
+  (cond ((string= flag "flag")
+	 "flagged")
+	((string= flag "read")
+	 "seen")
+	(t
+	 flag)))
+
+(cl-defmethod gnus-search-indexed-extract ((_engine gnus-search-mu))
+  (prog1
+      (let ((bol (line-beginning-position))
+	    (eol (line-end-position)))
+	(list (buffer-substring-no-properties bol eol)
+	      100))
+    (move-beginning-of-line 2)))
+
+(cl-defmethod gnus-search-indexed-search-command ((engine gnus-search-mu)
+						  (qstring string)
+						  query &optional groups)
+  (let ((limit (alist-get 'limit query))
+	(thread (alist-get 'thread query)))
+    (with-slots (switches config-directory) engine
+      `("find" 			; command must come first
+	"--nocolor"		; mu will always give coloured output otherwise
+	,(format "--muhome=%s" config-directory)
+	,@switches
+	,(if thread "-r" "")
+	,(if limit (format "--maxnum=%d" limit) "")
+	,qstring
+	,@(if groups
+	      `("and" "("
+		,@(nbutlast (mapcan (lambda (x)
+				      (list (concat "maildir:/" x) "or"))
+				    groups))
+		")")
+	    "")
+	"--format=plain"
+	"--fields=l"))))
+
 ;;; Find-grep interface
 
 (cl-defmethod gnus-search-transform-expression ((_engine gnus-search-find-grep)
-- 
2.30.2


[-- Attachment #2: Type: text/plain, Size: 178 bytes --]

Greetings,

This is as discussed on emacs-devel.

I haven't heard anything back from savannah.nongnu.org about repository
approval yet for the GNU ELPA package.

-- 
Thanks,
Jai

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Lars Ingebrigtsen]

Jai Flack <jflack@disroot.org> writes:

> Subject: [PATCH] An mu backend for gnus-search
>
> * lisp/gnus-search.el (gnus-search-mu-program): New defcustom
> (gnus-search-mu-switches): New defcustom

[...]

> I haven't heard anything back from savannah.nongnu.org about repository
> approval yet for the GNU ELPA package.

I haven't actually read the patch yet -- does this need an ELPA package
in addition to the patch included?  And I don't think the Savannah
people are involved in the GNU ELPA stuff -- we administer that
ourselves.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Corwin Brust]

On Sat, Apr 2, 2022 at 9:59 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> I haven't actually read the patch yet -- does this need an ELPA package
> in addition to the patch included?  And I don't think the Savannah
> people are involved in the GNU ELPA stuff -- we administer that
> ourselves.

Savannah, given approval, would provide a source repository for the
development of this feature and also a host for a dedicated page/site
for it but, as you say Lars, would not have anything to do with adding
it to GNU (or NONGNU) ELPA.

Jai,

Can you confirm that you applied for savannah hosting because you want
a dedicated git (or SVN, etc) repo for this work or a web-page/site
for it, etc?   If you don't need those things it might be best to
cancel that submission.

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Eric Abrahamsen]

On 04/02/22 16:58 PM, Lars Ingebrigtsen wrote:
> Jai Flack <jflack@disroot.org> writes:
>
>> Subject: [PATCH] An mu backend for gnus-search
>>
>> * lisp/gnus-search.el (gnus-search-mu-program): New defcustom
>> (gnus-search-mu-switches): New defcustom
>
> [...]
>
>> I haven't heard anything back from savannah.nongnu.org about repository
>> approval yet for the GNU ELPA package.
>
> I haven't actually read the patch yet -- does this need an ELPA package
> in addition to the patch included?  And I don't think the Savannah
> people are involved in the GNU ELPA stuff -- we administer that
> ourselves.

This was one of the questions in the original emacs.devel thread -- how
do we handle the situation where a package is both built-in and
available for installation from ELPA? Does anything special need to
happen in order to make sure the user is always using the newest
version?

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Eric Abrahamsen]

Corwin Brust <corwin@bru.st> writes:

> On Sat, Apr 2, 2022 at 9:59 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
>>
>> I haven't actually read the patch yet -- does this need an ELPA package
>> in addition to the patch included?  And I don't think the Savannah
>> people are involved in the GNU ELPA stuff -- we administer that
>> ourselves.
>
> Savannah, given approval, would provide a source repository for the
> development of this feature and also a host for a dedicated page/site
> for it but, as you say Lars, would not have anything to do with adding
> it to GNU (or NONGNU) ELPA.
>
> Jai,
>
> Can you confirm that you applied for savannah hosting because you want
> a dedicated git (or SVN, etc) repo for this work or a web-page/site
> for it, etc?   If you don't need those things it might be best to
> cancel that submission.

I thought you needed a user account via savannah in order to gain push
access to ELPA and Emacs? It's been a while now, but I thought my
account (ie the ability to log in here: https://savannah.gnu.org/) was
what provided that access.

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Lars Ingebrigtsen]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> This was one of the questions in the original emacs.devel thread -- how
> do we handle the situation where a package is both built-in and
> available for installation from ELPA? Does anything special need to
> happen in order to make sure the user is always using the newest
> version?

I'd rather have it all in-core if things are tightly coupled.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Corwin Brust]

On Sat, Apr 2, 2022 at 10:25 AM Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
>
>
> I thought you needed a user account via savannah in order to gain push
> access to ELPA and Emacs? It's been a while now, but I thought my
> account (ie the ability to log in here: https://savannah.gnu.org/) was
> what provided that access.

It is correct that an account on savannah is required for someone to
be granted push/committer access to Emacs (or most GNU projects).
That is completely separate from having a project registered at
savannah, however.  That latter is usually not needed unless you
require "forge" type capabilities for the project you are registering.

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Eric Abrahamsen]

Corwin Brust <corwin@bru.st> writes:

> On Sat, Apr 2, 2022 at 10:25 AM Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
>>
>>
>> I thought you needed a user account via savannah in order to gain push
>> access to ELPA and Emacs? It's been a while now, but I thought my
>> account (ie the ability to log in here: https://savannah.gnu.org/) was
>> what provided that access.
>
> It is correct that an account on savannah is required for someone to
> be granted push/committer access to Emacs (or most GNU projects).
> That is completely separate from having a project registered at
> savannah, however.  That latter is usually not needed unless you
> require "forge" type capabilities for the project you are registering.

My guess is this was just a small misunderstanding/misspeaking on Jai's
part. So far as I know they're only asking for the account.

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Corwin Brust]

On Sat, Apr 2, 2022 at 11:12 AM Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
>
> My guess is this was just a small misunderstanding/misspeaking on Jai's
> part. So far as I know they're only asking for the account.

OK, thanks.  I won't close the request until Jai has a chance to
confirm but I will add a note asking to hold processing of the request
pending clarification.

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Jai Flack]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> This was one of the questions in the original emacs.devel thread -- how
>> do we handle the situation where a package is both built-in and
>> available for installation from ELPA? Does anything special need to
>> happen in order to make sure the user is always using the newest
>> version?
>
> I'd rather have it all in-core if things are tightly coupled.

My only reason for the ELPA package was to make this available for users
of Emacs 28 (once it's released). If you don't think this is necessary
then I have no reason for the savannah project.

- -- 
Thanks,
Jai
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEMibxCPhhYAWzlyCbGp8lHZSJ3Z4FAmJJBfQACgkQGp8lHZSJ
3Z6U4w/9FQvR0R605JpQc9+VZ090dPSeATk8vV0dxC4l3CNRxfM2MY/BHN+7OF/5
+QCe+oZFvDWvGv5sPCh/cbwtiG7+pqOiPvtShF+bPT8oFtDLnRJZAlfOpsgTC8AB
rjoYmegBQ82BZOMtNxAPh4PxVcIJC6PQTq/BvMIxtrNY9Kngz/FIpk9LM2GD24M3
eK493vb088jdNikXeIvqqmt7GpT9bLJM62VlQDmPkZ7C2+OGx9ZeuDGWiS4OFMV5
DTQrj5o8zye2YEhp1mx1werO3oaUr9EOLRSJJ6OEsxlrpACyKQffCag8XRhikOJi
z2aOpVpKGSkePR1Eij9gnk9X6Ov9ZwFW3o/I9FhtqBYFNqS35liz/mJwZDTNYJpP
Hpd1Lck2zTR7wJsYiO7IEACmOx8WMSGDDS6Sc0vs4E3RyFOrZbeie2n7k25Nl5r9
E7FO37IOif4/lxKAMm0wWyHYteRZKotj/HcW5nY8DHivK2b65kQgpFXmEzLt1iqT
PvlWn4k1c+JrhvN/tyKxKFdRz3GUpRDADKdDyX1W81kvtNZuUFhRjdpUmolrA7nB
S3lJWnQwxSQwtrf3qtVRRgcT5WuUDsYELWWWEhLGHXKW7H6rX9JTaejW+34XJcRM
0aq9jtetjDjfpLkkIcFdZdzCrt53pkBzIq4xZlQeerpi8n+ziyk=
=e2Fg
-----END PGP SIGNATURE-----

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Jai Flack]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Apologies if this is a duplicate email, my reply to debbugs bounced.

Corwin Brust <corwin@bru.st> writes:

> On Sat, Apr 2, 2022 at 9:59 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
>>
>> I haven't actually read the patch yet -- does this need an ELPA package
>> in addition to the patch included?  And I don't think the Savannah
>> people are involved in the GNU ELPA stuff -- we administer that
>> ourselves.
>
> Savannah, given approval, would provide a source repository for the
> development of this feature and also a host for a dedicated page/site
> for it but, as you say Lars, would not have anything to do with adding
> it to GNU (or NONGNU) ELPA.
>
> Jai,
>
> Can you confirm that you applied for savannah hosting because you want
> a dedicated git (or SVN, etc) repo for this work or a web-page/site
> for it, etc?   If you don't need those things it might be best to
> cancel that submission.

I applied for the savannah hosting so I could move the git repository
for both this and my other isearch-olc package to it, not because I
thought it was required for ELPA inclusion.

- -- 
Thanks,
Jai
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEMibxCPhhYAWzlyCbGp8lHZSJ3Z4FAmJJBlQACgkQGp8lHZSJ
3Z54SQ//RPOt1A6E6lHeHecfj0KU0C82aEZsrqpfH0Ok/s5GsjI0QVAApfVMcYr2
kxl83Zx8T+p1qH6OindI0jEqMsBk68aShzMjBS3AthKQ8vunMavY2LHijBKmthlF
YBwRLHO0Bq8O/4bw9/4LTKFiP9tVKwgVbphWp/UV1dk43uC9ER1Snv0bPtalyVne
no9IfGLqcRuJJaF3UU2kG90dta2u59jjEHHzv3f4pZT/SHafDgeGx21zTQRZRnad
hwfNP99OJNH2TXg++VSkLpypRHQ9cgMlsPua04kUI/BfhwbrR2ZJr4ESoF+N5tf1
1ECM58LcdcJbRV+CxnVfjdY+Hb/5UwiT44r8/E1tG6/LqGGwY3iMWqvXaIelcvfG
Z1/LqMblZjvXnCuo49eSFzeTJ7Cg48HPAQvssQPPD6haTYCQfm2Rce+1K+N8tR/7
xJnZOkMwwXmk72d4Y617guPCfICzq3V75kJWzTVdB/woYkIjz6/hCY64tN7kQ3Ky
kVoMhPg1pikn+BhAqa56i4zstULj++W6duQhItYn6Af5gw9dzQGyZSNc7LYnZQlv
jkidB3736bgSrjvbcrskp2QDCAFiXJpOGE8BxJWfKVsr7iyupodXcEYedVFfQgt+
LXFR1Yz73JRPY6NNWbHhE5ilYqIr5Tb1vuhfPk9KkfB47EPhwnM=
=sn5c
-----END PGP SIGNATURE-----

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Lars Ingebrigtsen]

Jai Flack <jflack@posteo.net> writes:

> My only reason for the ELPA package was to make this available for users
> of Emacs 28 (once it's released). If you don't think this is necessary
> then I have no reason for the savannah project.

But the in-tree things are necessary for it to work, aren't they?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Jai Flack]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Jai Flack <jflack@posteo.net> writes:
>
>> My only reason for the ELPA package was to make this available for users
>> of Emacs 28 (once it's released). If you don't think this is necessary
>> then I have no reason for the savannah project.
>
> But the in-tree things are necessary for it to work, aren't they?

No they are identical code-wise.

I'm not sure if you read the discussion on emacs-devel but the issue of
having a duplicate feature in-tree and as a package for Emacs 28 was
briefly discussed without solution.

- -- 
Thanks,
Jai
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEMibxCPhhYAWzlyCbGp8lHZSJ3Z4FAmJJtNUACgkQGp8lHZSJ
3Z4KyQ//bGeaBWUsoEJhf8FfaSqJc0dMeC7GyG9/GkQBFz2iZJx6aGpBLM1lfTcz
OuXDBh430068bF3F4xjsJNiGcy1PkTqquY4ul8g9fRq+cU6Jq6ps0o3oi1OgJdCA
6viXV7Fy8OQpoG/OhtM74hL7bUbHzm0r/8US1XgEmUOfBJSv3l64K3r9URCfLiN4
7XDNJN8v/rmAt63qJ7+eIyuda+I7q8PXn8CmLjGMf/P/1XJt1fL7y3yAk2zVis/9
NcAIuxWa8cgoCb2zWBO2yCva1Wcu+Q0IeoRwz/p8Vpr7QtyRM2VW6TgKKDYYMJUP
dpT+vujjmEEYCCfWEWdwhsLJlZFDCHE9DPKnNpAXO9V69LvKhDRKr0X2an/ks1i+
5LEipWJKOOLtZe1u7ZaJh9tiIN2lrznm22hEQrtG9JDCBqNrhOyfbc0C6RlJqp1o
oLKelAPCcNfKeevRoZYDtM7Q87zmxABokts5xNg7lDegnBGyaRhKR6qQ+Uk4BpVF
cF8TuMBHPTvHhDjzqNWl+5CkfQpaofbvi8moRzQUb/X2D0AnlQCq8iIvThCss9JO
vhqV3jqZUBGKNEuzzrTUrYruLjAUUfcRK4frdw2l83EPmX64SvFhFbaB5xlHUf8X
WnzM97w6a7sSkr7Hq7prMaEqI8D+dZ9WcKTTcdWZ8SVHZaeC2/U=
=olBF
-----END PGP SIGNATURE-----

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Lars Ingebrigtsen]

Jai Flack <jflack@posteo.net> writes:

> I'm not sure if you read the discussion on emacs-devel but the issue of
> having a duplicate feature in-tree and as a package for Emacs 28 was
> briefly discussed without solution.

No, didn't read that.  Does that mean that the ELPA package doesn't work
in Emacs 29?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Jai Flack]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Jai Flack <jflack@posteo.net> writes:
>
>> I'm not sure if you read the discussion on emacs-devel but the issue of
>> having a duplicate feature in-tree and as a package for Emacs 28 was
>> briefly discussed without solution.
>
> No, didn't read that.  Does that mean that the ELPA package doesn't work
> in Emacs 29?

The package works fine, it just redefines some symbols (to an identical
definition); I would just prefer to avoid duplicated code if possible.

I'm not sure how many users there would be of this as an ELPA package
for one Emacs version so it's very possible it's not worth the effort.

-- 
Thanks,
Jai

(Can never seem to get signed emails from Gnus that also look right in
plaintext)

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Lars Ingebrigtsen]

Jai Flack <jflack@posteo.net> writes:

> I'm not sure how many users there would be of this as an ELPA package
> for one Emacs version so it's very possible it's not worth the effort.

I think just putting it in Emacs 29 is sufficient.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Jai Flack]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Jai Flack <jflack@posteo.net> writes:
>
>> I'm not sure how many users there would be of this as an ELPA package
>> for one Emacs version so it's very possible it's not worth the effort.
>
> I think just putting it in Emacs 29 is sufficient.

Right.

Any chance someone with push permission can give my patch a final
review please?

-- 
Thanks,
Jai

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Lars Ingebrigtsen]

Jai Flack <jflack@posteo.net> writes:

> Any chance someone with push permission can give my patch a final
> review please?

Looks OK to me, so I've pushed it to Emacs 29 with some minor changes to
the defcustom :types.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54662: 29.0.50; [PATCH] An mu backend for gnus-search

[Jai Flack]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Jai Flack <jflack@posteo.net> writes:
>
>> Any chance someone with push permission can give my patch a final
>> review please?
>
> Looks OK to me, so I've pushed it to Emacs 29 with some minor changes to
> the defcustom :types.

Thank you! 😁

-- 
Thanks,
Jai