bug#1736: [Hendrik Tews] movemail loops if hard links are not supported

bug#1736: [Hendrik Tews] movemail loops if hard links are not supported

[Sven Joachim]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

On filesystems that do not support hard links, movemail will enter an
endless loop.  It would probably be more prudent to error if link(2)
fails with EPERM.


[-- Attachment #2: Type: message/rfc822, Size: 2556 bytes --]

From: Hendrik Tews <tews@cs.ru.nl>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: Bug#384993: emacs21-bin-common: movemail loops if hard links are not supported
Date: Mon, 28 Aug 2006 13:18:22 +0200
Message-ID: <E1GHf8I-0001KX-PR@tandem.cs.ru.nl>

Package: emacs21-bin-common
Version: 21.4a-3
Severity: normal

movemail does not check the error code after creating the hard
link in line 344:

	  tem = link (tempname, lockname);

As a result it loops if the link fails with -1 EPERM (Operation
not permitted). This happens for instance on smbfs mounted
directories, because smbfs 3.0.22-1 does not support hard links
any more (it used to).


-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16-2-k7-smp
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages emacs21-bin-common depends on:
ii  emacs21-common                21.4a-3    The GNU Emacs editor's shared, arc
ii  libc6                         2.3.6-15   GNU C Library: Shared libraries

emacs21-bin-common recommends no packages.

-- no debconf information


Bye,

Hendrik

bug#1736: marked as done ([Hendrik Tews] movemail loops if hard links are not supported)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]


Your message dated Thu, 01 Jan 2009 04:35:36 -0500
with message-id <874p0jl66v.fsf@cyd.mit.edu>
and subject line Re: [Hendrik Tews] movemail loops if hard links are not supported
has caused the Emacs bug report #1736,
regarding [Hendrik Tews] movemail loops if hard links are not supported
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1736: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1736
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5041 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 158 bytes --]

On filesystems that do not support hard links, movemail will enter an
endless loop.  It would probably be more prudent to error if link(2)
fails with EPERM.


[-- Attachment #2.1.2: Type: message/rfc822, Size: 2556 bytes --]

From: Hendrik Tews <tews@cs.ru.nl>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: Bug#384993: emacs21-bin-common: movemail loops if hard links are not supported
Date: Mon, 28 Aug 2006 13:18:22 +0200
Message-ID: <E1GHf8I-0001KX-PR@tandem.cs.ru.nl>

Package: emacs21-bin-common
Version: 21.4a-3
Severity: normal

movemail does not check the error code after creating the hard
link in line 344:

	  tem = link (tempname, lockname);

As a result it loops if the link fails with -1 EPERM (Operation
not permitted). This happens for instance on smbfs mounted
directories, because smbfs 3.0.22-1 does not support hard links
any more (it used to).


-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16-2-k7-smp
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages emacs21-bin-common depends on:
ii  emacs21-common                21.4a-3    The GNU Emacs editor's shared, arc
ii  libc6                         2.3.6-15   GNU C Library: Shared libraries

emacs21-bin-common recommends no packages.

-- no debconf information


Bye,

Hendrik




[-- Attachment #3: Type: message/rfc822, Size: 1275 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Sven Joachim <svenjoac@gmx.de>
Cc: 1736-done@emacsbugs.donarmstrong.com
Subject: Re: [Hendrik Tews] movemail loops if hard links are not supported
Date: Thu, 01 Jan 2009 04:35:36 -0500
Message-ID: <874p0jl66v.fsf@cyd.mit.edu>

> On filesystems that do not support hard links, movemail will enter an
> endless loop.  It would probably be more prudent to error if link(2)
> fails with EPERM.

I've checked in the fix you suggested.  Thanks.