From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 36564@debbugs.gnu.org
Subject: bug#36564: 27.0.50; Wrong number of errors in compilation mode-line
Date: Fri, 12 Jul 2019 21:57:29 +0300 [thread overview]
Message-ID: <87d0ifm67a.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwvh87syzn3.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 11 Jul 2019 18:32:10 -0400")
>> --- a/lisp/progmodes/compile.el
>> +++ b/lisp/progmodes/compile.el
>> @@ -2245,6 +2250,8 @@ compilation-filter
>> (unless comint-inhibit-carriage-motion
>> (comint-carriage-motion (process-mark proc) (point)))
>> (set-marker (process-mark proc) (point))
>> + ;; Update the number of errors in compilation-mode-line-errors
>> + (font-lock-ensure compilation-filter-start (point))
>
> I worry that doing it there will slow down processing too much.
> But even if we want to do it there, I think font-lock-ensure is wrong
> because we shouldn't *highlight* (e.g. the user may prefer font-lock to
> be disabled).
>
> Does compilation--ensure-parse do what you want?
I tried compilation--ensure-parse, and it updates the number of errors,
so I replaced font-lock-ensure with compilation--ensure-parse.
next prev parent reply other threads:[~2019-07-12 18:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 20:25 bug#36564: 27.0.50; Wrong number of errors in compilation mode-line Juri Linkov
2019-07-10 22:34 ` Juri Linkov
2019-07-11 21:47 ` Juri Linkov
2019-07-11 22:02 ` Juri Linkov
2019-07-11 22:32 ` Stefan Monnier
2019-07-12 18:57 ` Juri Linkov [this message]
2019-07-12 20:09 ` Stefan Monnier
2019-07-13 22:04 ` Juri Linkov
2019-07-15 12:44 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0ifm67a.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=36564@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).