From: Juri Linkov <juri@linkov.net>
To: 36564@debbugs.gnu.org
Subject: bug#36564: 27.0.50; Wrong number of errors in compilation mode-line
Date: Thu, 11 Jul 2019 01:34:27 +0300 [thread overview]
Message-ID: <87ef2xmsct.fsf@mail.linkov.net> (raw)
In-Reply-To: <871ryzhskw.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 09 Jul 2019 23:25:15 +0300")
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
> Often compilation-mode displays wrong number of errors
> in the mode-line even when compilation is finished.
>
> compilation-mode is based on font-lock, so when the
> *compilation* buffer is not displayed during compilation,
> some parts of this buffer that contain error messages
> are not fontified, and thus these errors are not counted.
>
> This patch ensures the correct number of errors
> is displayed on the mode-line:
Actually maybe better to count errors not at the end
of compilation, but during compilation as output goes:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: compilation-font-lock-ensure.2.patch --]
[-- Type: text/x-diff, Size: 699 bytes --]
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 1a0d9bdbb7..7b319e9947 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -2245,6 +2250,8 @@ compilation-filter
(unless comint-inhibit-carriage-motion
(comint-carriage-motion (process-mark proc) (point)))
(set-marker (process-mark proc) (point))
+ ;; Update the number of errors in compilation-mode-line-errors
+ (font-lock-ensure compilation-filter-start (point))
;; (set (make-local-variable 'compilation-buffer-modtime)
;; (current-time))
(run-hooks 'compilation-filter-hook))
next prev parent reply other threads:[~2019-07-10 22:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 20:25 bug#36564: 27.0.50; Wrong number of errors in compilation mode-line Juri Linkov
2019-07-10 22:34 ` Juri Linkov [this message]
2019-07-11 21:47 ` Juri Linkov
2019-07-11 22:02 ` Juri Linkov
2019-07-11 22:32 ` Stefan Monnier
2019-07-12 18:57 ` Juri Linkov
2019-07-12 20:09 ` Stefan Monnier
2019-07-13 22:04 ` Juri Linkov
2019-07-15 12:44 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef2xmsct.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=36564@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).