From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#36564: 27.0.50; Wrong number of errors in compilation mode-line Date: Fri, 12 Jul 2019 21:57:29 +0300 Organization: LINKOV.NET Message-ID: <87d0ifm67a.fsf@mail.linkov.net> References: <871ryzhskw.fsf@mail.linkov.net> <87ef2xmsct.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="87622"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 36564@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 12 20:59:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hm0l9-000MeF-Sz for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jul 2019 20:59:08 +0200 Original-Received: from localhost ([::1]:51896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hm0l8-00070k-VX for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jul 2019 14:59:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36290) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hm0l5-00070J-Gh for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 14:59:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hm0l4-0001RC-IZ for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 14:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60150) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hm0l4-0001Qu-97 for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 14:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hm0l4-00026B-6g for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 14:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jul 2019 18:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 36564-submit@debbugs.gnu.org id=B36564.15629579268032 (code B ref 36564); Fri, 12 Jul 2019 18:59:02 +0000 Original-Received: (at 36564) by debbugs.gnu.org; 12 Jul 2019 18:58:46 +0000 Original-Received: from localhost ([127.0.0.1]:40738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hm0kn-00025T-Vv for submit@debbugs.gnu.org; Fri, 12 Jul 2019 14:58:46 -0400 Original-Received: from blue.elm.relay.mailchannels.net ([23.83.212.20]:48492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hm0kj-00025H-Eq for 36564@debbugs.gnu.org; Fri, 12 Jul 2019 14:58:42 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id AD996342BB3; Fri, 12 Jul 2019 18:58:39 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a71.g.dreamhost.com (100-96-14-124.trex.outbound.svc.cluster.local [100.96.14.124]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 300BC3428F1; Fri, 12 Jul 2019 18:58:39 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a71.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Fri, 12 Jul 2019 18:58:39 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Minister-Bored: 2fe1e4dc1f381d05_1562957919456_2219283789 X-MC-Loop-Signature: 1562957919456:2057652262 X-MC-Ingress-Time: 1562957919456 Original-Received: from pdx1-sub0-mail-a71.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a71.g.dreamhost.com (Postfix) with ESMTP id 5A1928020A; Fri, 12 Jul 2019 11:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=CFfBG1OUo/DkcPLaldnHEelhvHU=; b= Nhy/NdpkkGcV5uQQvjQdQPyuyCk8lRh4RqEYRAeVmQNpj5XJ4K+8rC5c3PJOeTWf k5jROqKZGuQNXsR/gKgLKjTz0KumOS2p8PUI0Qn3qb4F3RKClEKGX27T3o1nzaRP ZeaJnzB+yyFqxVlZY033jHQvMsYSO7sbNIYbBPGXuO0= Original-Received: from mail.jurta.org (m91-129-103-134.cust.tele2.ee [91.129.103.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a71.g.dreamhost.com (Postfix) with ESMTPSA id 49A5D801F1; Fri, 12 Jul 2019 11:58:30 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a71 In-Reply-To: (Stefan Monnier's message of "Thu, 11 Jul 2019 18:32:10 -0400") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrhedtgddufedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrddufeegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrudefgedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehmohhnnhhivghrsehirhhordhumhhonhhtrhgvrghlrdgtrgenucevlhhushhtvghrufhiiigvpedt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162800 Archived-At: >> --- a/lisp/progmodes/compile.el >> +++ b/lisp/progmodes/compile.el >> @@ -2245,6 +2250,8 @@ compilation-filter >> (unless comint-inhibit-carriage-motion >> (comint-carriage-motion (process-mark proc) (point))) >> (set-marker (process-mark proc) (point)) >> + ;; Update the number of errors in compilation-mode-line-errors >> + (font-lock-ensure compilation-filter-start (point)) > > I worry that doing it there will slow down processing too much. > But even if we want to do it there, I think font-lock-ensure is wrong > because we shouldn't *highlight* (e.g. the user may prefer font-lock to > be disabled). > > Does compilation--ensure-parse do what you want? I tried compilation--ensure-parse, and it updates the number of errors, so I replaced font-lock-ensure with compilation--ensure-parse.