From: Michael Albinus <michael.albinus@gmx.de>
To: Juri Linkov <juri@linkov.net>
Cc: Mikhail P <mikpom@fastmail.com>, 45256@debbugs.gnu.org
Subject: bug#45256: Viewing images over network using TRAMP (errors and unexpected prompts)
Date: Thu, 17 Dec 2020 09:44:01 +0100 [thread overview]
Message-ID: <87czz8zusu.fsf@gmx.de> (raw)
In-Reply-To: <87zh2djyc2.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 16 Dec 2020 22:52:05 +0200")
Juri Linkov <juri@linkov.net> writes:
Hi Juri,
>> From my pov, image-fit-to-window must be hardened in order to avoid this
>> reentrant call. Maybe an internal lock at entry, which is honored by
>> every next call until the lock is removed.
>
> The simplest solution is just to increase the number of seconds
> in the user option 'image-auto-resize-on-window-resize'
> proportionally to network latency.
That's a global variable, right? So you would also delay resizing of
images located locally.
> Locking could be implemented as well. How would be better to do this?
> Maybe by using a buffer-local variable?
Yes. Something like
--8<---------------cut here---------------start------------->8---
(defvar image-fit-to-window-lock nil
"Lock for `image-fit-to-window' timer."
(defun image-fit-to-window (window)
"..."
(unless image-fit-to-window-lock
(unwind-protect
(progn
(setq-local image-fit-to-window-lock t)
...)
(setq image-fit-to-window-lock nil))))
--8<---------------cut here---------------end--------------->8---
There's also another thread. When image-fit-to-window is called from
Emacs the first time, there could also be a running Tramp operation,
which would be disturbed. See the recent discussion about "Tramp and
timers" in the emacs-devel ML. Tramp would detect this situation, and
fire the (new) error remote-file-error. This must also be handled, like
--8<---------------cut here---------------start------------->8---
(defun image-fit-to-window (window)
"..."
(ignore-error 'remote-file-error
...))
--8<---------------cut here---------------end--------------->8---
Best regards, Michael.
next prev parent reply other threads:[~2020-12-17 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 12:17 bug#45256: Viewing images over network using TRAMP (errors and unexpected prompts) Mikhail P
2020-12-16 9:08 ` Michael Albinus
2020-12-16 20:52 ` Juri Linkov
2020-12-17 8:44 ` Michael Albinus [this message]
2020-12-17 21:59 ` Juri Linkov
2020-12-18 8:05 ` Michael Albinus
2020-12-18 8:29 ` Juri Linkov
2020-12-18 9:58 ` Michael Albinus
2020-12-19 20:19 ` Juri Linkov
2020-12-22 14:49 ` Mikhail Pomaznoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czz8zusu.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=45256@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=mikpom@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).