From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#45256: Viewing images over network using TRAMP (errors and unexpected prompts) Date: Thu, 17 Dec 2020 09:44:01 +0100 Message-ID: <87czz8zusu.fsf@gmx.de> References: <461b6a4f-9709-c71b-0ec3-f70d08674c9e@fastmail.com> <87360615l3.fsf@gmx.de> <87zh2djyc2.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9744"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Mikhail P , 45256@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 17 09:45:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpouM-0002OM-LD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Dec 2020 09:45:10 +0100 Original-Received: from localhost ([::1]:47600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpouL-00037M-MO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Dec 2020 03:45:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpouE-00037C-0U for bug-gnu-emacs@gnu.org; Thu, 17 Dec 2020 03:45:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51317) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpouD-0005D6-Oo for bug-gnu-emacs@gnu.org; Thu, 17 Dec 2020 03:45:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kpouD-00057D-Kg for bug-gnu-emacs@gnu.org; Thu, 17 Dec 2020 03:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Dec 2020 08:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45256 X-GNU-PR-Package: emacs Original-Received: via spool by 45256-submit@debbugs.gnu.org id=B45256.160819465619590 (code B ref 45256); Thu, 17 Dec 2020 08:45:01 +0000 Original-Received: (at 45256) by debbugs.gnu.org; 17 Dec 2020 08:44:16 +0000 Original-Received: from localhost ([127.0.0.1]:34630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpotU-00055u-BD for submit@debbugs.gnu.org; Thu, 17 Dec 2020 03:44:16 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:56363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpotR-00055b-FD for 45256@debbugs.gnu.org; Thu, 17 Dec 2020 03:44:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1608194643; bh=X5Wh/uj8VEzfXpgOO15lwxuiMkPuQfiL+JwraHomN0A=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=S+Nlly7Gb9BE62PBS88db2X4E62cKiKQMKdqV/KyKOiDizRom1wxXo1e9bWQsNova rPh5QUbZdHvygEfqkCUGtp6m+upP/dc0lwCS8GG+i7S7RDr++RJ3Fbnb04FBL7uOOb mvtt6v3hfNgdX3UCxdnrKlPV+M1HaQfpY6WTk+zQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.118.184]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MbRfl-1kEHHe0321-00bryG; Thu, 17 Dec 2020 09:44:03 +0100 In-Reply-To: <87zh2djyc2.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 16 Dec 2020 22:52:05 +0200") X-Provags-ID: V03:K1:UVg9L14s899W/2v5rN1bqPH9KbPq4xDT4D15p+DboRLDYpNtvh0 FQiqgsZxt0lu5g4IKJLCbw873x7Uewy8qcEypu+l7Hs61tQfyDpPMUc/Qp52wJBs+M++F2A 5syYQXLSeZlWtZP5xkVARwWmNvMfgpt7gEeX1Ba5/seb/y3rhi9+aMha+Ox5ZHujfkVONSD S/ci/aDedVCqHrAVcso3A== X-UI-Out-Filterresults: notjunk:1;V03:K0:socJtKosTCA=:L9gojYNFt/9N5/S96jTJjt q91LJkBXsMEsqY/eFZYg86/9qMWDZZGE9SkCCbkQ48wJC/GQQJq9gakdH+HGSY1TXzMn/+Vbw uF5kz8Sq1xPwN3GuGyOY5WIYivJPCl17yHsAF1821NTb/pmVOpNEfTBCLM//ijz+ahymUCoA3 xmEKImW/SSIyJGP1wroP41z3FLpWZToQqMkCNeZpzHKVgeRf1r+lOKWl9TeBALPQIxd/mi0CT MRPJQ5LNeNxPftTsoz1IiOsPHJMsSlQdtxEmn6kkLUotl5i9O/dpC81/6ySI+o92Zj4sFzWqM 2GVKd8TrrmxHaHJ11lyB1EUdOP0XK/z12jMhSc6aMHnLnN9Jr4X6BCARxqsrnWaefcb/ym+ow hFw9ixOGzmT2BdJguTsiHhhkngpcVHbRMx1zm/n5SwgxouasBo2eBBl5Vr9I+aKvL6re+X2/R NunDM15RoUMTnF64PwCnluthxjqnujbp2bl56QE2ipZbmScLa9gYdUawoMT61ZPXLLQP8ZsQj +sjbOtsYT/oLSlAqVNNLhECwpNwj11toqrtFaFTdxouRaZjNTQ8bjbOveR2JqwslsvSt0zQEM 6IEFSumfAm+LnJcf30IpHzeG9HETmpUk70w0Hfhd6DS7NWIAME7WI12uop86Jqm3LXFTgHaLT cqsu6Jpcw7fpUdTnlUh3UO0e/BdJaE+GFCxdL2DQVUTRrjuKP7tK/eqeyift6NV1tsFppvbVg 4IqJM0YjKJ+nOhvbVshpQNZn1FdrfYzakomvZU9AgVWHE7aILFny/4XhyNYAq/Y0tB9CPWsd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196239 Archived-At: Juri Linkov writes: Hi Juri, >> From my pov, image-fit-to-window must be hardened in order to avoid this >> reentrant call. Maybe an internal lock at entry, which is honored by >> every next call until the lock is removed. > > The simplest solution is just to increase the number of seconds > in the user option 'image-auto-resize-on-window-resize' > proportionally to network latency. That's a global variable, right? So you would also delay resizing of images located locally. > Locking could be implemented as well. How would be better to do this? > Maybe by using a buffer-local variable? Yes. Something like --8<---------------cut here---------------start------------->8--- (defvar image-fit-to-window-lock nil "Lock for `image-fit-to-window' timer." (defun image-fit-to-window (window) "..." (unless image-fit-to-window-lock (unwind-protect (progn (setq-local image-fit-to-window-lock t) ...) (setq image-fit-to-window-lock nil)))) --8<---------------cut here---------------end--------------->8--- There's also another thread. When image-fit-to-window is called from Emacs the first time, there could also be a running Tramp operation, which would be disturbed. See the recent discussion about "Tramp and timers" in the emacs-devel ML. Tramp would detect this situation, and fire the (new) error remote-file-error. This must also be handled, like --8<---------------cut here---------------start------------->8--- (defun image-fit-to-window (window) "..." (ignore-error 'remote-file-error ...)) --8<---------------cut here---------------end--------------->8--- Best regards, Michael.