From: Michael Albinus <michael.albinus@gmx.de>
To: Juri Linkov <juri@linkov.net>
Cc: Mikhail P <mikpom@fastmail.com>, 45256@debbugs.gnu.org
Subject: bug#45256: Viewing images over network using TRAMP (errors and unexpected prompts)
Date: Fri, 18 Dec 2020 09:05:45 +0100 [thread overview]
Message-ID: <87zh2by1wm.fsf@gmx.de> (raw)
In-Reply-To: <87mtycgkkk.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 17 Dec 2020 23:59:55 +0200")
Juri Linkov <juri@linkov.net> writes:
Hi Juri,
> Additionally to these changes, I also added canceling the previous timer
> before starting a new timer to avoid several simultaneously started timers.
> This improved responsiveness in non-remote case. In remote case it helps
> a little too, but still needs the lock for extremely slow connections.
Why cancelling the *previous* timer? It has done already part of the
job, so I would expect it will finish faster than a newly started timer.
> Here is a complete patch (BTW, I'm not sure if the check for file-remote-p
> can be removed now):
Yes. file-readable-p has performed already a remote operation (it runs
"test -r <filename>"), so a test file-remote-p doesn't make sense.
You haven't protected the timer function against the
remote-file-error. Are you sure it cannot happen?
Best regards, Michael.
next prev parent reply other threads:[~2020-12-18 8:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 12:17 bug#45256: Viewing images over network using TRAMP (errors and unexpected prompts) Mikhail P
2020-12-16 9:08 ` Michael Albinus
2020-12-16 20:52 ` Juri Linkov
2020-12-17 8:44 ` Michael Albinus
2020-12-17 21:59 ` Juri Linkov
2020-12-18 8:05 ` Michael Albinus [this message]
2020-12-18 8:29 ` Juri Linkov
2020-12-18 9:58 ` Michael Albinus
2020-12-19 20:19 ` Juri Linkov
2020-12-22 14:49 ` Mikhail Pomaznoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh2by1wm.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=45256@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=mikpom@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).