From: Lars Ingebrigtsen <larsi@gnus.org>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: 50667@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#50667: Update ecomplete when used via standard UI
Date: Fri, 05 Nov 2021 04:28:41 +0100 [thread overview]
Message-ID: <87cznfmgba.fsf@gnus.org> (raw)
In-Reply-To: <871r5l1tud.fsf@gmail.com> (Augusto Stoffel's message of "Sat, 18 Sep 2021 23:01:30 +0200")
Augusto Stoffel <arstoffel@gmail.com> writes:
> If one keeps sets
>
> (setq message-mail-alias-type nil ;; or keep the default 'abbrev
> message-expand-name-standard-ui t)
>
> and an ecomplete database file, then everything works OOTB, except that
> the ecomplete database doesn't get updated with new addresses.
[...]
> - (when (and (message-mail-alias-type-p 'ecomplete)
> + (when (and (bound-and-true-p ecomplete-database)
> (not message-inhibit-ecomplete))
> (message-put-addresses-in-ecomplete))
There wasn't any response for Stefan for what he was thinking when
adding the standard-ui variable 😀, but this can't be the correct
solution. If message-mail-alias-type isn't 'ecomplete, there's nothing
to tell the code here that we want to put addresses in ecomplete.
Furthermore, this would break the functionality of that setting --
ecomplete-database will be nil when you start, so it'll never put
anything there.
So I think the right solution here (if you want to combine these two
things) is to put message-put-addresses-in-ecomplete into
message-sent-hook. So I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-11-05 3:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 21:01 bug#50667: Update ecomplete when used via standard UI Augusto Stoffel
2021-09-18 21:06 ` Lars Ingebrigtsen
2021-09-18 21:35 ` Augusto Stoffel
2021-09-19 15:10 ` Lars Ingebrigtsen
2021-09-19 16:02 ` Augusto Stoffel
2021-11-05 3:28 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cznfmgba.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=50667@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).