From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50667: Update ecomplete when used via standard UI Date: Fri, 05 Nov 2021 04:28:41 +0100 Message-ID: <87cznfmgba.fsf@gnus.org> References: <871r5l1tud.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23984"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 50667@debbugs.gnu.org, Stefan Monnier To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 05 05:12:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1miqac-00062f-0S for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Nov 2021 05:12:30 +0100 Original-Received: from localhost ([::1]:53140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miqaa-0007Hs-Ip for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Nov 2021 00:12:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mipuY-0003xt-TO for bug-gnu-emacs@gnu.org; Thu, 04 Nov 2021 23:29:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60869) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mipuY-0005Kl-Ij for bug-gnu-emacs@gnu.org; Thu, 04 Nov 2021 23:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mipuY-0006eZ-HA for bug-gnu-emacs@gnu.org; Thu, 04 Nov 2021 23:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Nov 2021 03:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50667 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50667-submit@debbugs.gnu.org id=B50667.163608293725549 (code B ref 50667); Fri, 05 Nov 2021 03:29:02 +0000 Original-Received: (at 50667) by debbugs.gnu.org; 5 Nov 2021 03:28:57 +0000 Original-Received: from localhost ([127.0.0.1]:44179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mipuT-0006e1-Aa for submit@debbugs.gnu.org; Thu, 04 Nov 2021 23:28:57 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mipuR-0006dm-Ae for 50667@debbugs.gnu.org; Thu, 04 Nov 2021 23:28:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wLptvfvWUgcrvClUI+ewzT/e5fspoXL/XuhfCfnG19U=; b=qVOVPhIm/VKkUtJlKtF6KyYEHU pFWdnXeEP8my0Dlhyt0YO1z47SKFrqK8ryHzMbeolSG1IZ180A5i/1EWEFgmO4ciVaRaaFC/Xw98L wNMHlXCRlr3j+5zq/RQbt0Cj3Iwm0DyMXnxAECUQx3uF6s7vIkUB5C+4pdVZpNwUP6fc=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mipuH-0000hf-6E; Fri, 05 Nov 2021 04:28:47 +0100 X-Now-Playing: Fairport Convention's _Come All Ye (5)_: "White Dress" In-Reply-To: <871r5l1tud.fsf@gmail.com> (Augusto Stoffel's message of "Sat, 18 Sep 2021 23:01:30 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218968 Archived-At: Augusto Stoffel writes: > If one keeps sets > > (setq message-mail-alias-type nil ;; or keep the default 'abbrev > message-expand-name-standard-ui t) > > and an ecomplete database file, then everything works OOTB, except that > the ecomplete database doesn't get updated with new addresses. [...] > - (when (and (message-mail-alias-type-p 'ecomplete) > + (when (and (bound-and-true-p ecomplete-database) > (not message-inhibit-ecomplete)) > (message-put-addresses-in-ecomplete)) There wasn't any response for Stefan for what he was thinking when adding the standard-ui variable =F0=9F=98=80, but this can't be the correct solution. If message-mail-alias-type isn't 'ecomplete, there's nothing to tell the code here that we want to put addresses in ecomplete. Furthermore, this would break the functionality of that setting -- ecomplete-database will be nil when you start, so it'll never put anything there. So I think the right solution here (if you want to combine these two things) is to put message-put-addresses-in-ecomplete into message-sent-hook. So I'm closing this bug report. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no