From: Augusto Stoffel <arstoffel@gmail.com>
To: 50667@debbugs.gnu.org
Subject: bug#50667: Update ecomplete when used via standard UI
Date: Sat, 18 Sep 2021 23:01:30 +0200 [thread overview]
Message-ID: <871r5l1tud.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
Tags: patch
If one keeps sets
(setq message-mail-alias-type nil ;; or keep the default 'abbrev
message-expand-name-standard-ui t)
and an ecomplete database file, then everything works OOTB, except that
the ecomplete database doesn't get updated with new addresses.
Is the following change a reasonable fix for this?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnus-message.el-message-send-Always-update-ecomplete.patch --]
[-- Type: text/patch, Size: 876 bytes --]
From 9cc0c8d8dd8343bc615f2a4a18e38e8940c340cb Mon Sep 17 00:00:00 2001
From: Augusto Stoffel <arstoffel@gmail.com>
Date: Sat, 18 Sep 2021 22:51:00 +0200
Subject: [PATCH] * gnus/message.el (message-send): Always update ecomplete if
loaded
---
lisp/gnus/message.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index 4a754b9856..98a70330c4 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -4391,7 +4391,7 @@ message-send
(run-hooks 'message-sent-hook))
(message "Sending...done")
;; Do ecomplete address snarfing.
- (when (and (message-mail-alias-type-p 'ecomplete)
+ (when (and (bound-and-true-p ecomplete-database)
(not message-inhibit-ecomplete))
(message-put-addresses-in-ecomplete))
;; Mark the buffer as unmodified and delete auto-save.
--
2.31.1
next reply other threads:[~2021-09-18 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 21:01 Augusto Stoffel [this message]
2021-09-18 21:06 ` bug#50667: Update ecomplete when used via standard UI Lars Ingebrigtsen
2021-09-18 21:35 ` Augusto Stoffel
2021-09-19 15:10 ` Lars Ingebrigtsen
2021-09-19 16:02 ` Augusto Stoffel
2021-11-05 3:28 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r5l1tud.fsf@gmail.com \
--to=arstoffel@gmail.com \
--cc=50667@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).