unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 44849@debbugs.gnu.org
Subject: bug#44849: [PATCH] Make XEmacs compat variable warning-level-aliases obsolete
Date: Wed, 25 Nov 2020 08:19:35 +0100	[thread overview]
Message-ID: <87blfl29a0.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkm=AR5OCRcKZjfTBXwXoMt+Asf4==NqZbz==D0xdve7-mw@mail.gmail.com> (Stefan Kangas's message of "Tue, 24 Nov 2020 10:09:23 -0800")

Stefan Kangas <stefan@marxist.se> writes:

> The `warning-level-aliases' exists only to provide compatibility with
> XEmacs warning levels.  I don't think this is very useful these days.
>
> I propose to make it obsolete and warn when one of these levels are
> used.  Please see the attached patch.

I'm slightly worried that these aliases are used out there in
out-of-tree packages.  As a test, I grepped the GNU ELPA tree, but this
was the only place where the aliases are used:

(defun muse-display-warning (message)
  "Display the given MESSAGE as a warning."
  (if (fboundp 'display-warning)
      (display-warning 'muse message
                       (if (featurep 'xemacs)
                           'warning
                         :warning))

And that's behind a featurep check, so it's fine, too.

So I think the proposed change is probably fine.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2020-11-25  7:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24 18:09 bug#44849: [PATCH] Make XEmacs compat variable warning-level-aliases obsolete Stefan Kangas
2020-11-24 19:52 ` Basil L. Contovounesios
2020-11-24 20:15   ` Stefan Kangas
2020-11-24 21:00     ` Basil L. Contovounesios
2020-11-24 21:40       ` Stefan Kangas
2020-11-25  7:19 ` Lars Ingebrigtsen [this message]
2020-12-10 17:24   ` Stefan Kangas
2020-12-14 13:20     ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blfl29a0.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=44849@debbugs.gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).