From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44849: [PATCH] Make XEmacs compat variable warning-level-aliases obsolete Date: Wed, 25 Nov 2020 08:19:35 +0100 Message-ID: <87blfl29a0.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6036"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44849@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 25 08:20:37 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khp6S-0001T2-I3 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Nov 2020 08:20:36 +0100 Original-Received: from localhost ([::1]:37030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khp6R-00027i-Es for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Nov 2020 02:20:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khp5u-00026Y-QA for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 02:20:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50723) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khp5u-0007R9-IQ for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 02:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1khp5u-0007T1-De for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 02:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Nov 2020 07:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44849 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44849-submit@debbugs.gnu.org id=B44849.160628878628675 (code B ref 44849); Wed, 25 Nov 2020 07:20:02 +0000 Original-Received: (at 44849) by debbugs.gnu.org; 25 Nov 2020 07:19:46 +0000 Original-Received: from localhost ([127.0.0.1]:34036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khp5e-0007SR-Iy for submit@debbugs.gnu.org; Wed, 25 Nov 2020 02:19:46 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:34074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khp5d-0007SF-Bj for 44849@debbugs.gnu.org; Wed, 25 Nov 2020 02:19:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gXekmnM1hJx3oq/4QP9n8u3FVKgMu1smTfU69wgKOCw=; b=EEGm/eV2B4uEmJprUSaMMBrhxi hgPG1ZdBeL3ri9E4Ui8D9R+I29sEEKfyyyFJk/fw8wry6OYS7QUMwdTS5MMJyvxi/1fqupUvVAa9B 55N1yKhe2Jd7aEy8kGpNjCY6cBaBEMTeT9YUqrWKtu00iWL5ItCLRHqUN5+qEpJd7S/Y=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khp5U-0004bq-9P; Wed, 25 Nov 2020 08:19:38 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUfHxglJRpMSDZY WUzCnHb///86tvQhAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QLGQY4HBzTRjYAAAGvSURBVDjLbZSB saQgDIYDbgEBLQDiFaCEAvZW+q/pEmAV3rvMLO7km/8PgSgYJ+HpiX1niQPqg7nmYmfR4QmpShwZ MC4iyF9NPKCI6rxUu+ADoijUITof6XUIgAjUFAgAshiDr3cD3coBVuAEICAKANeJAvltb13FagYG tuMBflAoMA3c1asCt7reVror1AVWXb7Fawba2oK6lQ1uSBujQPomt/2t5b8AUBUa2znYqDdJ7xUk mKMpEDbGKf9Ycfhp1UE6alW5i7rLG6zHWx/27AfXgRx/qNVX/gWQ5Zl2jhMA8EGO6FVSPn8oTr8g 5HLlT3yAHkawAv6Uki+awWk92nJxvniwMk5GIgSxSlyYfLxrIDCE3eTy2QsnisOuMrqFi3gpoKlz WEoNne8BwAlbAxcTjyBKex3wBGAEoYN22UvNZr54F8WqYG/1O5BOOmjzeSsyxzp2dw3TCsjRhxkA N0C/gM8VON+Af6ZDjjfRaeqwTkDe+RQJ/wMsJ0kbuMGCAdCCNSlZIggzkE8DxOQTu4QK3GAFcnmG qJQPLLAOHx5i1ual0w+Dvb843yFs4n/BFVwBr38MeAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0x MS0yNVQwNjo1NjoyOCswMDowML0a2v8AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTEtMjVUMDY6 NTY6MjgrMDA6MDDMR2JDAAAAAElFTkSuQmCC X-Now-Playing: Modern English's _Mesh & Lace_: "A Viable Commercial" In-Reply-To: (Stefan Kangas's message of "Tue, 24 Nov 2020 10:09:23 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194164 Archived-At: Stefan Kangas writes: > The `warning-level-aliases' exists only to provide compatibility with > XEmacs warning levels. I don't think this is very useful these days. > > I propose to make it obsolete and warn when one of these levels are > used. Please see the attached patch. I'm slightly worried that these aliases are used out there in out-of-tree packages. As a test, I grepped the GNU ELPA tree, but this was the only place where the aliases are used: (defun muse-display-warning (message) "Display the given MESSAGE as a warning." (if (fboundp 'display-warning) (display-warning 'muse message (if (featurep 'xemacs) 'warning :warning)) And that's behind a featurep check, so it's fine, too. So I think the proposed change is probably fine. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no