From: Stefan Kangas <stefan@marxist.se>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 44849@debbugs.gnu.org
Subject: bug#44849: [PATCH] Make XEmacs compat variable warning-level-aliases obsolete
Date: Tue, 24 Nov 2020 12:15:56 -0800 [thread overview]
Message-ID: <CADwFkmm=Ko-kYetzEJuuCJhd6yq_GFpo2KLt5uFPkiZpj2S4bg@mail.gmail.com> (raw)
In-Reply-To: <87v9duttuw.fsf@tcd.ie>
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Stefan Kangas <stefan@marxist.se> writes:
>
>> @@ -256,8 +257,10 @@ display-warning
>> (setq level :warning))
>> (unless buffer-name
>> (setq buffer-name "*Warnings*"))
>> - (if (assq level warning-level-aliases)
>> - (setq level (cdr (assq level warning-level-aliases))))
>> + (with-suppressed-warnings ((obsolete warning-level-aliases))
>> + (when-let ((new (cdr-safe (assq level warning-level-aliases))))
>
> Why the cdr-safe?
To avoid this:
(and (assq level warning-level-aliases)
(cdr (assq level warning-level-aliases)))
next prev parent reply other threads:[~2020-11-24 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 18:09 bug#44849: [PATCH] Make XEmacs compat variable warning-level-aliases obsolete Stefan Kangas
2020-11-24 19:52 ` Basil L. Contovounesios
2020-11-24 20:15 ` Stefan Kangas [this message]
2020-11-24 21:00 ` Basil L. Contovounesios
2020-11-24 21:40 ` Stefan Kangas
2020-11-25 7:19 ` Lars Ingebrigtsen
2020-12-10 17:24 ` Stefan Kangas
2020-12-14 13:20 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmm=Ko-kYetzEJuuCJhd6yq_GFpo2KLt5uFPkiZpj2S4bg@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=44849@debbugs.gnu.org \
--cc=contovob@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).