bug#23339: 24.5; align-region assumes that match does not contain newline

bug#23339: 24.5; align-region assumes that match does not contain newline

[Josh]

The align-region function assumes that a matching regexp does not
contain a newline.  This causes unexpected behavior in cases where the
first "column" being aligned contains only whitespace.  The following
script exhibits the unexpected behavior:

emacs -Q --eval '(progn
 (switch-to-buffer "*test*")
 (text-mode)
 (setq indent-tabs-mode nil)
 (insert "lorem ipsum, dolor sit amet,\n ,,\n")
 (let ((table (make-syntax-table (syntax-table))))
   ;; (modify-syntax-entry ?\n ">" table) ; <= UNCOMMENT THIS LINE TO FIX
   (with-syntax-table table
   (align-regexp (point-min) (point-max) "\\(\\s-*\\)," 1 1 t))))'

Uncommenting the seventh line and running again will show the expected
behavior.  The fix works around the problem by using a syntax map in
which the newline character does not belong to the whitespace syntax
class, thus preventing \s-* from matching the newline.


In GNU Emacs 24.5.1 (x86_64-apple-darwin13.4.0, NS apple-appkit-1265.21)
 of 2015-04-10 on builder10-9.porkrind.org
Windowing system distributor `Apple', version 10.3.1348
Configured using:
 `configure --with-ns '--enable-locallisppath=/Library/Application
 Support/Emacs/${version}/site-lisp:/Library/Application
 Support/Emacs/site-lisp''

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Text

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns mail-prsvr mail-utils align time-date tooltip electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
cocoa ns multi-tty emacs)

Memory information:
((conses 16 72780 5795)
 (symbols 48 17281 0)
 (miscs 40 39 123)
 (strings 32 10041 4622)
 (string-bytes 1 277927)
 (vectors 16 9051)
 (vector-slots 8 373020 18497)
 (floats 8 53 150)
 (intervals 56 167 0)
 (buffers 960 12))

bug#23339: 24.5; align-region assumes that match does not contain newline

[Lars Ingebrigtsen]

[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]

Josh <josh+gnu@nispio.net> writes:

> The align-region function assumes that a matching regexp does not
> contain a newline.  This causes unexpected behavior in cases where the
> first "column" being aligned contains only whitespace.  The following
> script exhibits the unexpected behavior:
>
> emacs -Q --eval '(progn
>  (switch-to-buffer "*test*")
>  (text-mode)
>  (setq indent-tabs-mode nil)
>  (insert "lorem ipsum, dolor sit amet,\n ,,\n")
>  (let ((table (make-syntax-table (syntax-table))))
>    ;; (modify-syntax-entry ?\n ">" table) ; <= UNCOMMENT THIS LINE TO FIX
>    (with-syntax-table table
>    (align-regexp (point-min) (point-max) "\\(\\s-*\\)," 1 1 t))))'
>
> Uncommenting the seventh line and running again will show the expected
> behavior.  The fix works around the problem by using a syntax map in
> which the newline character does not belong to the whitespace syntax
> class, thus preventing \s-* from matching the newline.

(This bug report unfortunately got no response at the time.)

You don't specify what the result is you're seeing, and what you expect
to see, so I'm not sure whether this is fixed or not.  When I try your
recipe in Emacs 26.1-28, I get:


[-- Attachment #2: Type: image/png, Size: 7123 bytes --]

[-- Attachment #3: Type: text/plain, Size: 217 bytes --]


Which I think is correct behaviour?  

Are you still seeing buggy behaviour here in more recent Emacs versions?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#23339: 24.5; align-region assumes that match does not contain newline

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Are you still seeing buggy behaviour here in more recent Emacs versions?

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no