unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Peter Münster" <pm@a16n.net>
To: Stefan Kangas <stefan@marxist.se>
Cc: 52200@debbugs.gnu.org
Subject: bug#52200: 29.0.50; image-dired-cmd-create-standard-thumbnail-options
Date: Thu, 15 Sep 2022 19:59:57 +0200	[thread overview]
Message-ID: <87bkrgikma.fsf@a16n.net> (raw)
In-Reply-To: <87sftq4uj3.fsf@a16n.net> ("Peter Münster"'s message of "Fri, 14 Jan 2022 08:59:44 +0100")

And here the same patch for the latest master:

diff --git a/lisp/image/image-dired-external.el b/lisp/image/image-dired-external.el
index 223d881bcf..fcf2e2edb6 100644
--- a/lisp/image/image-dired-external.el
+++ b/lisp/image/image-dired-external.el
@@ -128,15 +128,13 @@ image-dired-cmd-optipng-options
   :link '(url-link "man:optipng(1)"))
 
 (defcustom image-dired-cmd-create-standard-thumbnail-options
-  (append '("-size" "%wx%h" "%f[0]")
-          (unless (or image-dired-cmd-pngcrush-program
-                      image-dired-cmd-pngnq-program)
-            (list
-             "-set" "Thumb::MTime" "%m"
-             "-set" "Thumb::URI" "file://%f"
-             "-set" "Description" "Thumbnail of file://%f"
-             "-set" "Software" (emacs-version)))
-          '("-thumbnail" "%wx%h>" "png:%t"))
+  (let ((opts (list "-size" "%wx%h" "%f[0]"
+                    "-set" "Thumb::MTime" "%m"
+                    "-set" "Thumb::URI" "file://%f"
+                    "-set" "Description" "Thumbnail of file://%f"
+                    "-set" "Software" (emacs-version)
+                    "-thumbnail" "%wx%h>" "png:%t")))
+    (if (executable-find "gm") (cons "convert" opts) opts))
   "Options for creating thumbnails according to the Thumbnail Managing Standard.
 Available format specifiers are the same as in
 `image-dired-cmd-create-thumbnail-options', with %m for file modification time."

-- 
           Peter





  reply	other threads:[~2022-09-15 17:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30 16:24 bug#52200: 29.0.50; image-dired-cmd-create-standard-thumbnail-options Peter Münster
2021-12-09  2:01 ` Stefan Kangas
2022-01-14  7:59   ` Peter Münster
2022-09-15 17:59     ` Peter Münster [this message]
2022-09-16  0:39       ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkrgikma.fsf@a16n.net \
    --to=pm@a16n.net \
    --cc=52200@debbugs.gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).