From: Stefan Kangas <stefan@marxist.se>
To: "Peter Münster" <pm@a16n.net>
Cc: 52200@debbugs.gnu.org
Subject: bug#52200: 29.0.50; image-dired-cmd-create-standard-thumbnail-options
Date: Wed, 8 Dec 2021 18:01:50 -0800 [thread overview]
Message-ID: <CADwFkmnr-8nNYAjkCPhgURG0xCAjCdn=Dkg33oc8J43WYiQu=A@mail.gmail.com> (raw)
In-Reply-To: <87o861k3x9.fsf@a16n.net> ("Peter Münster"'s message of "Tue, 30 Nov 2021 17:24:02 +0100")
Peter Münster <pm@a16n.net> writes:
> I'm a bit confused about
> image-dired-cmd-create-standard-thumbnail-options:
>
> - It seems, that it's not used with pngcrush or pngnq, so this test is
> perhaps useless:
> (unless (or image-dired-cmd-pngcrush-program
> image-dired-cmd-pngnq-program) ...
I think the intention is that we shouldn't insert those text fields
twice. See the removed code in commit 36b9973dec65 and also
`image-dired-cmd-pngcrush-options'.
Perhaps we could make this unconditional, but then what should we do
about `image-dired-cmd-pngcrush-options'? Should the options be removed
from there?
> - If gm is used, then the "convert" command should be added.
Yes, I think you are right.
next prev parent reply other threads:[~2021-12-09 2:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 16:24 bug#52200: 29.0.50; image-dired-cmd-create-standard-thumbnail-options Peter Münster
2021-12-09 2:01 ` Stefan Kangas [this message]
2022-01-14 7:59 ` Peter Münster
2022-09-15 17:59 ` Peter Münster
2022-09-16 0:39 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmnr-8nNYAjkCPhgURG0xCAjCdn=Dkg33oc8J43WYiQu=A@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=52200@debbugs.gnu.org \
--cc=pm@a16n.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).