From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Peter =?UTF-8?Q?M=C3=BCnster?= Newsgroups: gmane.emacs.bugs Subject: bug#52200: 29.0.50; image-dired-cmd-create-standard-thumbnail-options Date: Thu, 15 Sep 2022 19:59:57 +0200 Message-ID: <87bkrgikma.fsf@a16n.net> References: <87o861k3x9.fsf@a16n.net> <87sftq4uj3.fsf@a16n.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7107"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52200@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 15 20:01:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYtBC-0001jK-Oq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Sep 2022 20:01:38 +0200 Original-Received: from localhost ([::1]:56188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYtBB-0005oY-K3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Sep 2022 14:01:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYtAd-0005mZ-Sr for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2022 14:01:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42202) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYtAc-0001RG-8R for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2022 14:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYtAc-0000ry-1y for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2022 14:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Peter =?UTF-8?Q?M=C3=BCnster?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2022 18:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52200 X-GNU-PR-Package: emacs Original-Received: via spool by 52200-submit@debbugs.gnu.org id=B52200.16632648023149 (code B ref 52200); Thu, 15 Sep 2022 18:01:02 +0000 Original-Received: (at 52200) by debbugs.gnu.org; 15 Sep 2022 18:00:02 +0000 Original-Received: from localhost ([127.0.0.1]:59134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYt9d-0000oZ-K5 for submit@debbugs.gnu.org; Thu, 15 Sep 2022 14:00:02 -0400 Original-Received: from smtp2-g21.free.fr ([212.27.42.2]:1184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYt9c-0000o7-0H for 52200@debbugs.gnu.org; Thu, 15 Sep 2022 14:00:00 -0400 Original-Received: from server.a16n.net (unknown [82.65.98.121]) by smtp2-g21.free.fr (Postfix) with ESMTPS id 70FEF2003ED; Thu, 15 Sep 2022 19:59:58 +0200 (CEST) Original-Received: from ws.localdomain (unknown [192.168.13.254]) by server.a16n.net (Postfix) with ESMTPSA id 0DB238004AE; Thu, 15 Sep 2022 19:59:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=a16n.net; s=a16n; t=1663264798; bh=G09umVw+cETdDwMYYUse0HpUPF99xAx6+ifYEd2F5dI=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=Vp1NkIB0Rc3dlhdR79r6p2UOap/i2Aha+wJFdxQDu2sylo0yg/kyp2JczaTQ5jpIL oRL4jTOnC2ZS3vVMcamXzDFH2lX4cl15q51LAsGLudaK6iCfpFWnnkG1mLvXO7BUlO 9g1Qxt1xzkOwQxG0dZXTGvEYli1YliizYnx0lxRdjVlUwn7n/Gu06b5MfuscJ+NzjO 97PtY/rrnli0pZsoYVgZrLcWvo7X2cCMlVYysEiS1IO+O5tmtMoLF1YaocRNU8TL2O 6sTWY5Ge8lD4Uq2c/wiJehgvIkWmMFfRE/8ibOzYjmOPNkbJL0iZPTsMoPPUMDSOd0 Fp0kcJw9ce9ew== Original-Received: by ws.localdomain (Postfix, from userid 1000) id D3FD420624; Thu, 15 Sep 2022 19:59:57 +0200 (CEST) In-Reply-To: <87sftq4uj3.fsf@a16n.net> ("Peter =?UTF-8?Q?M=C3=BCnster?="'s message of "Fri, 14 Jan 2022 08:59:44 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242626 Archived-At: And here the same patch for the latest master: diff --git a/lisp/image/image-dired-external.el b/lisp/image/image-dired-external.el index 223d881bcf..fcf2e2edb6 100644 --- a/lisp/image/image-dired-external.el +++ b/lisp/image/image-dired-external.el @@ -128,15 +128,13 @@ image-dired-cmd-optipng-options :link '(url-link "man:optipng(1)")) (defcustom image-dired-cmd-create-standard-thumbnail-options - (append '("-size" "%wx%h" "%f[0]") - (unless (or image-dired-cmd-pngcrush-program - image-dired-cmd-pngnq-program) - (list - "-set" "Thumb::MTime" "%m" - "-set" "Thumb::URI" "file://%f" - "-set" "Description" "Thumbnail of file://%f" - "-set" "Software" (emacs-version))) - '("-thumbnail" "%wx%h>" "png:%t")) + (let ((opts (list "-size" "%wx%h" "%f[0]" + "-set" "Thumb::MTime" "%m" + "-set" "Thumb::URI" "file://%f" + "-set" "Description" "Thumbnail of file://%f" + "-set" "Software" (emacs-version) + "-thumbnail" "%wx%h>" "png:%t"))) + (if (executable-find "gm") (cons "convert" opts) opts)) "Options for creating thumbnails according to the Thumbnail Managing Standard. Available format specifiers are the same as in `image-dired-cmd-create-thumbnail-options', with %m for file modification time." -- Peter