From: Visuwesh <visuweshm@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@iro.umontreal.ca, 58041@debbugs.gnu.org
Subject: bug#58041: [PATCH] docview: Use svg images when using mupdf for conversion
Date: Thu, 12 Jan 2023 13:50:24 +0530 [thread overview]
Message-ID: <87bkn4xiyf.fsf@gmail.com> (raw)
In-Reply-To: <83pmbkkw91.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 12 Jan 2023 10:11:38 +0200")
[வியாழன் ஜனவரி 12, 2023] Eli Zaretskii wrote:
>> >> I suppose so. But I'm not really sure if users out in the wild adjust
>> >> the variable.
>> >
>> > I set it to nil because of the blurriness.
>> >> If they do, then it might be worth looking into ignoring
>> >> that variable if we're generating SVG images.
>> >
>> > Ah, that'd be a good option, indeed.
>>
>> Right, then I guess adjustment of that sort is in order. How about the
>> following patch? It should be safe enough to go to emacs-29.
>
> Since this is not fixing a bug, I'd prefer it to go to master.
IMO it would be better to go to emacs-29 since it prevents wasteful
(re-)generation of SVG files but if you insist, master is fine by me.
>> [...]
>> +Note that MuPDF SVG generation is known to sometimes generate files
>> +that are buggy or can take a long time to render.
>
> The last sentence makes me wonder why we made a less-than-perfect
> option the default. It's against our usual conservative approach.
When I daily drove the patch to test it, I did not hit into the troubles
mentioned above so I turned the feature on by default but if the
troubles come up a lot more often, then I agree that it should be off by
default.
next prev parent reply other threads:[~2023-01-12 8:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 10:18 bug#58041: [PATCH] docview: Use svg images when using mupdf for conversion Visuwesh
2022-09-24 12:10 ` Lars Ingebrigtsen
[not found] ` <jwva62yxevs.fsf-monnier+emacs@gnu.org>
2023-01-08 6:09 ` Visuwesh
2023-01-09 14:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-09 16:32 ` Visuwesh
2023-01-09 17:18 ` Gregory Heytings
2023-01-09 23:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-12 6:43 ` Visuwesh
2023-01-12 8:11 ` Eli Zaretskii
2023-01-12 8:20 ` Visuwesh [this message]
2023-01-12 8:48 ` Eli Zaretskii
2023-01-12 16:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-14 8:33 ` Eli Zaretskii
2023-01-12 16:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-12 16:47 ` Visuwesh
2023-01-12 21:11 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkn4xiyf.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=58041@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).