From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#58041: [PATCH] docview: Use svg images when using mupdf for conversion Date: Thu, 12 Jan 2023 13:50:24 +0530 Message-ID: <87bkn4xiyf.fsf@gmail.com> References: <87k05t848c.fsf@gmail.com> <87eds5zhf7.fsf@gmail.com> <87v8lfy8g5.fsf@gmail.com> <87fscgxng0.fsf@gmail.com> <83pmbkkw91.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5382"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: monnier@iro.umontreal.ca, 58041@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 12 09:21:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFsq6-0001B0-Tp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Jan 2023 09:21:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFspt-0003uu-Ai; Thu, 12 Jan 2023 03:21:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFspa-0003sN-DE for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 03:21:12 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFspa-00022T-2J for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 03:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pFspZ-00050N-Tz for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 03:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Jan 2023 08:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58041 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58041-submit@debbugs.gnu.org id=B58041.167351163719198 (code B ref 58041); Thu, 12 Jan 2023 08:21:01 +0000 Original-Received: (at 58041) by debbugs.gnu.org; 12 Jan 2023 08:20:37 +0000 Original-Received: from localhost ([127.0.0.1]:44525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFspB-0004zZ-6f for submit@debbugs.gnu.org; Thu, 12 Jan 2023 03:20:37 -0500 Original-Received: from mail-pj1-f68.google.com ([209.85.216.68]:51793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFsp8-0004zH-3T for 58041@debbugs.gnu.org; Thu, 12 Jan 2023 03:20:36 -0500 Original-Received: by mail-pj1-f68.google.com with SMTP id n12so18420365pjp.1 for <58041@debbugs.gnu.org>; Thu, 12 Jan 2023 00:20:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vgU/5niwAizBtQBbjVcu4G/W4Ty7M1pWjesiXL/jblo=; b=QyWwTqp898e7yfWwNxPJYKVHFoG5ofQBnkXpT7qUCtBVAb8BHsPbE3KDHmGK3so70X CCrzs4YCcQ36ch4LN+NoEUyh4DiYrr1tm1SpQS2R9QhNr7lIekDG1LWGSOnBhJ2koHhE 8s5kcjtLPAJsBdmTwHnM3btv945wygJO22GdGZUnDxyzAZob+z9ovaoIBbouI9aP+7dp JbTLbrzQyqIht6O3gEx7qlfW3MvwjwZFtDlF0+WKJfrE5EAInkhRxhEhu82iG5NzrTpA PNwAa3btJIn/mBKKRFWP3o5GYGZWf/BlTteoF0It7PMrj4rfNnz+4+pCmhN4SjkL51GB HWAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vgU/5niwAizBtQBbjVcu4G/W4Ty7M1pWjesiXL/jblo=; b=lJdR/MBdYVYSDpBh1z4mzHlPPJ7JwAoG7SpOJ9ZS8L2AMMepWYBDwuwAAgT6g3wtBv spqu6cGJsgHmlko6MduKwXphHfaJU6S3ILr/w/qe235j1pbPRAOu5BmJ82P0qO+Fp6Jp uwpcV/wAG0MjA4Iu602kF4zDaxddnuH5/DSiWIDn6hWKXq6VBW0b/RyhCp5k5CPYPTa5 AykZEVd3Y0+OT57FpurEOU2Ab4yNLf8I9RaQS5QX537xHAM5Trrb6QRAMn7UG/bIXzqy HXuVLvlpuglplo0vOeFvZxBFWZFNpbzwnRE9/sn8wABNqMsAPxqzlc6kXfkuA/6FvhrT TzlQ== X-Gm-Message-State: AFqh2kqrvz2FCohlA7SirWw6cr19lKJpA2Ex8jYFgkc97qX/u+N4X8Q8 PtWAisjc5lWsPJX8IhwyzZs= X-Google-Smtp-Source: AMrXdXsPMtD4f4PFTD+dZ3yWksEfWtEKug/0KHBsFZb0RbXyUKODklb+YDZKWNf460itFoQD3duS8A== X-Received: by 2002:a17:90a:7e14:b0:219:eeb9:943f with SMTP id i20-20020a17090a7e1400b00219eeb9943fmr76771658pjl.49.1673511628102; Thu, 12 Jan 2023 00:20:28 -0800 (PST) Original-Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id a6-20020a656546000000b00478fbfd5276sm9508805pgw.15.2023.01.12.00.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 00:20:27 -0800 (PST) In-Reply-To: <83pmbkkw91.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 12 Jan 2023 10:11:38 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253183 Archived-At: [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE=9C= =E0=AE=A9=E0=AE=B5=E0=AE=B0=E0=AE=BF 12, 2023] Eli Zaretskii wrote: >> >> I suppose so. But I'm not really sure if users out in the wild adjust >> >> the variable. >> > >> > I set it to nil because of the blurriness. >> >> If they do, then it might be worth looking into ignoring >> >> that variable if we're generating SVG images. >> > >> > Ah, that'd be a good option, indeed. >>=20 >> Right, then I guess adjustment of that sort is in order. How about the >> following patch? It should be safe enough to go to emacs-29. > > Since this is not fixing a bug, I'd prefer it to go to master. IMO it would be better to go to emacs-29 since it prevents wasteful (re-)generation of SVG files but if you insist, master is fine by me. >> [...] >> +Note that MuPDF SVG generation is known to sometimes generate files >> +that are buggy or can take a long time to render. > > The last sentence makes me wonder why we made a less-than-perfect > option the default. It's against our usual conservative approach. When I daily drove the patch to test it, I did not hit into the troubles mentioned above so I turned the feature on by default but if the troubles come up a lot more often, then I agree that it should be off by default.