unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Visuwesh <visuweshm@gmail.com>
Cc: 58041@debbugs.gnu.org
Subject: bug#58041: [PATCH] docview: Use svg images when using mupdf for conversion
Date: Mon, 09 Jan 2023 09:51:42 -0500	[thread overview]
Message-ID: <jwvbkn722qj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87eds5zhf7.fsf@gmail.com> (Visuwesh's message of "Sun, 08 Jan 2023 11:39:16 +0530")

>>> Attached patch makes mupdf produce svg images rather than png when svg
>>> support is available.  This makes a noticeable improvement in image
>>> quality when zooming in.
>> IIUC this means that `+` and `-` now don't need to re-process the PDF, right?
>> I think this is particularly valuable for things like ODT where `+/-`
>> was pretty slow (because it re-created the PDF each time before having
>> a chance to focus on the current page).
> It depends on the value of `doc-view-scale-internally'.  The default
> value (t) implies that we change the :width image property which leads
> to blurry images when zooming.  In my case, even without zooming in, the
> image quality was noticeably worse.

So `doc-view-scale-internally` should default to nil when we use SVGs, right?

> If `doc-view-scale-internally' is nil though, what you say happens.

IIUC you're saying here that when `doc-view-scale-internally` is nil we
re-create the SVGs every time the users try to zoom in/out?  While not
strictly a bug, it's a significant inefficiency we should address, no?

Another thing that's odd now is that we use
`doc-view-pdf->png-converter-function` to convert to SVG, despite
its name.

>> Other reasons it's worth mentioning in NEWS is because there's a new
>> Custom to control it, and because it causes a regression for those LaTeX
>> files which end up embedding bitmap fonts.  I just bumped into one and
>> couldn't understand why every page took almost a minute to load;
>> Removing `\usepackage[T1]{fontenc}` fixed the problem.
> For the most part, I assumed MuPDF's svg and png conversion was
> one-to-one.  My testing with small docx and Excel files went smooth so I
> didn't think this feature warranted a NEWS entry.

I don't know exactly what happens with those LaTeX-generated PDF files,
indeed.  I haven't bumped into the problem with any other PDF files yet
(including scans).  But those PDF files with embedded bitmap fonts used
the be the norm in the LaTeX world in some distant past, so I'm sure
some of our users will bump into them.


        Stefan






  reply	other threads:[~2023-01-09 14:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-24 10:18 bug#58041: [PATCH] docview: Use svg images when using mupdf for conversion Visuwesh
2022-09-24 12:10 ` Lars Ingebrigtsen
     [not found] ` <jwva62yxevs.fsf-monnier+emacs@gnu.org>
2023-01-08  6:09   ` Visuwesh
2023-01-09 14:51     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-01-09 16:32       ` Visuwesh
2023-01-09 17:18         ` Gregory Heytings
2023-01-09 23:02         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-12  6:43           ` Visuwesh
2023-01-12  8:11             ` Eli Zaretskii
2023-01-12  8:20               ` Visuwesh
2023-01-12  8:48                 ` Eli Zaretskii
2023-01-12 16:27                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-14  8:33                     ` Eli Zaretskii
2023-01-12 16:33             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-12 16:47               ` Visuwesh
2023-01-12 21:11                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvbkn722qj.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=58041@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).