From: Stephen Berman <stephen.berman@gmx.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 46889@debbugs.gnu.org, "Mattias Engdegård" <mattiase@acm.org>,
"Harald Jörg" <haj@posteo.de>
Subject: bug#46889: Help version guesser bug (was: bug#46889: cperl-mode: Fix indentation issues [PATCH])
Date: Fri, 05 Mar 2021 11:30:06 +0100 [thread overview]
Message-ID: <87a6rh7v0x.fsf@rub.de> (raw)
In-Reply-To: <87im68uwld.fsf@hajtower>
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
On Thu, 04 Mar 2021 19:16:29 +0100 Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Mattias Engdegård <mattiase@acm.org> writes:
>
>> `rx-define` is new in Emacs 27, and the patch was apparently intended
>> to work with 26.1.
>
> I was fooled by the version guesser:
>
> ---
> rx-define is an autoloaded Lisp macro in ‘rx.el’.
>
> (rx-define NAME [(ARGS...)] RX)
>
> Probably introduced at or before Emacs version 24.
> ---
>
> I wonder where that is coming from... rx-define isn't mentioned in
> NEWS.24?
It's because help-fns--first-release finds this line in NEWS.27:
** Further functions and variables obsolete since Emacs 24 have been removed:
On the assumption that in the NEWS files a first-level outline header
contains the relevant reference to the first release and doesn't contain
a reference to an earlier release, the following patch fixes the bug:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: help-fns--first-release patch --]
[-- Type: text/x-patch, Size: 703 bytes --]
diff --git a/lisp/help-fns.el b/lisp/help-fns.el
index 290bebf7e5..01d3756bf0 100644
--- a/lisp/help-fns.el
+++ b/lisp/help-fns.el
@@ -668,7 +668,7 @@ help-fns--first-release
;; Almost all entries are of the form "* ... in Emacs NN.MM."
;; but there are also a few in the form "* Emacs NN.MM is a bug
;; fix release ...".
- (if (not (re-search-backward "^\\*.* Emacs \\([0-9.]+[0-9]\\)"
+ (if (not (re-search-backward "^\\* .* Emacs \\([0-9.]+[0-9]\\)"
nil t))
(message "Ref found in non-versioned section in %S"
(file-name-nondirectory f))
[-- Attachment #3: Type: text/plain, Size: 18 bytes --]
Steve Berman
next prev parent reply other threads:[~2021-03-05 10:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 14:43 bug#46889: cperl-mode: Fix indentation issues [PATCH] Harald Jörg
2021-03-04 17:31 ` Lars Ingebrigtsen
2021-03-04 18:07 ` Mattias Engdegård
2021-03-04 18:16 ` Lars Ingebrigtsen
2021-03-04 18:23 ` Mattias Engdegård
2021-03-04 18:34 ` Lars Ingebrigtsen
2021-03-05 10:30 ` Stephen Berman [this message]
2021-03-05 13:06 ` bug#46889: Help version guesser bug Lars Ingebrigtsen
2021-03-04 18:19 ` bug#46889: cperl-mode: Fix indentation issues [PATCH] Harald Jörg
2021-03-09 17:06 ` Harald Jörg
2021-03-09 17:18 ` Harald Jörg
2021-03-10 14:42 ` Lars Ingebrigtsen
2021-05-17 15:28 ` Lars Ingebrigtsen
2021-05-17 21:31 ` Harald Jörg
2021-05-18 13:47 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6rh7v0x.fsf@rub.de \
--to=stephen.berman@gmx.net \
--cc=46889@debbugs.gnu.org \
--cc=haj@posteo.de \
--cc=larsi@gnus.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).