unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: haj@posteo.de (Harald Jörg)
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 46889@debbugs.gnu.org, "Mattias Engdegård" <mattiase@acm.org>
Subject: bug#46889: cperl-mode: Fix indentation issues [PATCH]
Date: Mon, 17 May 2021 21:31:34 +0000	[thread overview]
Message-ID: <871ra5m4i1.fsf@hajtower> (raw)
In-Reply-To: <87im3hidl6.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 17 May 2021 17:28:53 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> haj@posteo.de (Harald Jörg) writes:
>>
>>> My patch has not been merged yet, and this is just as well: I'd like to
>>> withdraw it and re-work parts of it.  This will take a day or two (or
>>> more).  I also found that I've introduced a (minor) fontification bug.
>>
>> Sure; no problem.
>
> This was two months ago.  Did you make any progress here?

Oh - thanks for the reminder.  I forgot that this bug has the "patch"
tag set.

I did make progress - but not enough (yet) and also in a slightly
different direction.

That patch rolled three different stories into one:
 1) replace regex strings by rx forms as suggested by Mattias
 2) fix some indentation bugs (but broke some fontification regexes)
 3) start a mechanism to allow cperl-mode to understand syntax
    extensions.

This wasn't a good idea.

I'd like to split that into at least three separate commits (which I can
do by myself now, since I'm a member of the Emacs group now.  Thanks!).

I suggest to throw this patch away.  There's no specific bug in this bug
report number 46889.  I used the bug mechanism to provide a patch
without commit rights, but that path is no longer needed.  When a commit
fixes one of the old open bugs, I can just report that in the commit
message.

Thanks for your patience!
-- 
Cheers,
haj





  reply	other threads:[~2021-05-17 21:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 14:43 bug#46889: cperl-mode: Fix indentation issues [PATCH] Harald Jörg
2021-03-04 17:31 ` Lars Ingebrigtsen
2021-03-04 18:07   ` Mattias Engdegård
2021-03-04 18:16     ` Lars Ingebrigtsen
2021-03-04 18:23       ` Mattias Engdegård
2021-03-04 18:34         ` Lars Ingebrigtsen
2021-03-05 10:30       ` bug#46889: Help version guesser bug (was: bug#46889: cperl-mode: Fix indentation issues [PATCH]) Stephen Berman
2021-03-05 13:06         ` bug#46889: Help version guesser bug Lars Ingebrigtsen
2021-03-04 18:19   ` bug#46889: cperl-mode: Fix indentation issues [PATCH] Harald Jörg
2021-03-09 17:06 ` Harald Jörg
2021-03-09 17:18 ` Harald Jörg
2021-03-10 14:42   ` Lars Ingebrigtsen
2021-05-17 15:28     ` Lars Ingebrigtsen
2021-05-17 21:31       ` Harald Jörg [this message]
2021-05-18 13:47         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871ra5m4i1.fsf@hajtower \
    --to=haj@posteo.de \
    --cc=46889@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).