From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#46889: Help version guesser bug (was: bug#46889: cperl-mode: Fix indentation issues [PATCH]) Date: Fri, 05 Mar 2021 11:30:06 +0100 Message-ID: <87a6rh7v0x.fsf@rub.de> References: <87im68uwld.fsf@hajtower> <87tupqvn9i.fsf@gnus.org> <726A49CD-3D7F-44A3-A09F-F5C32F22EB28@acm.org> <87im66vl6q.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38469"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46889@debbugs.gnu.org, Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Harald =?UTF-8?Q?J=C3=B6rg?= To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 05 11:31:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lI7jq-0009uf-VM for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Mar 2021 11:31:18 +0100 Original-Received: from localhost ([::1]:41222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lI7jq-00026B-19 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Mar 2021 05:31:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lI7ja-00025l-Vi for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 05:31:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49629) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lI7ja-0006S7-CI for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 05:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lI7ja-0002TH-7Q for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 05:31:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87im68uwld.fsf@hajtower> Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Mar 2021 10:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46889 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46889-submit@debbugs.gnu.org id=B46889.16149402259447 (code B ref 46889); Fri, 05 Mar 2021 10:31:02 +0000 Original-Received: (at 46889) by debbugs.gnu.org; 5 Mar 2021 10:30:25 +0000 Original-Received: from localhost ([127.0.0.1]:32942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lI7iy-0002SJ-Pl for submit@debbugs.gnu.org; Fri, 05 Mar 2021 05:30:25 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:41821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lI7it-0002S0-Q5 for 46889@debbugs.gnu.org; Fri, 05 Mar 2021 05:30:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1614940209; bh=pXtbLdCg1MZUT9zy2SfUm0OW9rnDbcwFYAeqCxUqAXg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date; b=cW0NzZ5oFXzuD8HUK2UnhnNC0BdKmYcUF9URU3U8xCU9EVuL7qDCbiEC/c2XjdB52 mG3hiq1jZ5WyXbJ/wf0hwB9NPF8bRmMCl1js5ACiDCcBm+S/8XDQTta1czkweXsK3R nYMtLX4Ws319bi84sM1sKUitXCUmvpUplr+Xs15U= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobe-jhalfs ([188.109.206.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mel81-1lsq7I0eKD-00apj7; Fri, 05 Mar 2021 11:30:09 +0100 X-Provags-ID: V03:K1:f21mcv0whc27F3AKOAwAw+ALtYkrPF07nfx3MsnAZGi5vc8EeM/ LFMPQBsl5XVTJY8mnTBJ/Vj4a4rCNgWMp3CIo2Yji+Qt1rO0jpYmS27aLH2hGc0gIGaSswi j7/w3KR2tNiCfr+zTnqLsOtvDuaIiTCHRXroUL5ihZjGHp5L0QKiRnFiVi4zmyOQabxFcpz OEH5LPLi6Y6c92YBCMBzQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:4RHrSnT9Phk=:+LG08hbJSTbudSkBlUu5Mi 9QzAxFOfvfQX24+JNd6n0B70oOmChlrc53qqDubvabtiTCz5O2myz/Yc/LZkxevTvqBYZKCoX uwyhiBriaau5VPpv9fBVhPBxIc8I2LAQgsKTSBB6vui1+nDbPWzqc+QeSIF8RrsvmnX7OSabe pnIZemCuUo84aRMVI4xn4VqU4/YL+GhHOOxalQY8/JzZa8q0mLRPVpRZ+vQC+00NycFLPAo9u ERMwOUc6jL5coiLDDatpa/qJUL1V78R+hCEGrKE+NkMiSX97QcnvVizkq4gRrzqX95YDbaJsy +jMLIXQB9jWlMDR70jl07WIytewKypIlDSVDIno3y2gPWYFivqH8eKPfqhZ5N3XjtTMtnBY1p Juxa2O6m6SO/wKCBBakFtBTl5EX5SCFsu4Uz2TcgT6csjT0iJ9CZMSkm/1VXFacxR6HQbkKt4 Y7qJvnOIKO3UCy2vG3ZwKnELCwgxOcJUte0SliFU9eywFkWKb1F91eTDaTgusIenLW0fvN7JB +zZdCEONnN4aJzVr1fFlEANQ1nm4Sy6A1/eHLi/gBN4fprNbVaRRbpHX6xloB1hLMO7bUqVFw I/224FsKdiv2ONgk+VXMlnNfWWZqwHOWtMs7tkqEprcjeH/JDhtSE8ebBynpJePIktaMpFaCQ 6NOE+ILvFwga7U4BO+Pod/t3u9Lw/9JgbpUUHQP5Zj09sojwRBZk/jRf8zERu3u+o2NZjz8CG gw/oCVa2ajSZDptagUSQz+2FqDgKkfbPPOih9qra5oDiPRR8vI6WkIVi0xjZTBUvH//Kwtu7 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201519 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, 04 Mar 2021 19:16:29 +0100 Lars Ingebrigtsen wrote: > Mattias Engdeg=C3=A5rd writes: > >> `rx-define` is new in Emacs 27, and the patch was apparently intended >> to work with 26.1. > > I was fooled by the version guesser: > > --- > rx-define is an autoloaded Lisp macro in =E2=80=98rx.el=E2=80=99. > > (rx-define NAME [(ARGS...)] RX) > > Probably introduced at or before Emacs version 24. > --- > > I wonder where that is coming from... rx-define isn't mentioned in > NEWS.24? It's because help-fns--first-release finds this line in NEWS.27: ** Further functions and variables obsolete since Emacs 24 have been remove= d: On the assumption that in the NEWS files a first-level outline header contains the relevant reference to the first release and doesn't contain a reference to an earlier release, the following patch fixes the bug: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: help-fns--first-release patch diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 290bebf7e5..01d3756bf0 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -668,7 +668,7 @@ help-fns--first-release ;; Almost all entries are of the form "* ... in Emacs NN.MM." ;; but there are also a few in the form "* Emacs NN.MM is a bug ;; fix release ...". - (if (not (re-search-backward "^\\*.* Emacs \\([0-9.]+[0-9]\\)" + (if (not (re-search-backward "^\\* .* Emacs \\([0-9.]+[0-9]\\)" nil t)) (message "Ref found in non-versioned section in %S" (file-name-nondirectory f)) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Steve Berman --=-=-=--