* bug#6980: Could goto-char please have its own history list?
@ 2010-09-03 22:24 Lennart Borgman
2011-08-10 19:50 ` Juri Linkov
0 siblings, 1 reply; 7+ messages in thread
From: Lennart Borgman @ 2010-09-03 22:24 UTC (permalink / raw)
To: 6980
I can't see no reason its history should be mixed by something else.
(More than devel historic reasons ;-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#6980: Could goto-char please have its own history list?
2010-09-03 22:24 bug#6980: Could goto-char please have its own history list? Lennart Borgman
@ 2011-08-10 19:50 ` Juri Linkov
2011-08-10 21:41 ` Drew Adams
2021-02-17 8:51 ` Juri Linkov
0 siblings, 2 replies; 7+ messages in thread
From: Juri Linkov @ 2011-08-10 19:50 UTC (permalink / raw)
To: Lennart Borgman; +Cc: 6980
> I can't see no reason its history should be mixed by something else.
> (More than devel historic reasons ;-)
It makes sense to share the same history that contains only numeric
values between all commands that use `read-number', like
e.g. `goto-line' and `goto-char' (with some changes), because
non-numeric values (added to the history from other commands)
are useless for such number-reading commands.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#6980: Could goto-char please have its own history list?
2011-08-10 19:50 ` Juri Linkov
@ 2011-08-10 21:41 ` Drew Adams
2011-08-18 11:52 ` Juri Linkov
2021-02-17 8:51 ` Juri Linkov
1 sibling, 1 reply; 7+ messages in thread
From: Drew Adams @ 2011-08-10 21:41 UTC (permalink / raw)
To: 'Juri Linkov', 'Lennart Borgman'; +Cc: 6980
> > I can't see no reason its history should be mixed by something else.
> > (More than devel historic reasons ;-)
>
> It makes sense to share the same history that contains only numeric
> values between all commands that use `read-number', like
> e.g. `goto-line' and `goto-char' (with some changes), because
> non-numeric values (added to the history from other commands)
> are useless for such number-reading commands.
I don't have much of an opinion about the suggestion.
There are always pros & cons to making a history more or less specific.
But I'll point out that just because non-numeric histories are inappropriate for
numeric input does not mean that the same numeric history should be used for all
numeric inputs.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#6980: Could goto-char please have its own history list?
2011-08-10 21:41 ` Drew Adams
@ 2011-08-18 11:52 ` Juri Linkov
2011-08-18 12:27 ` Lennart Borgman
0 siblings, 1 reply; 7+ messages in thread
From: Juri Linkov @ 2011-08-18 11:52 UTC (permalink / raw)
To: Drew Adams; +Cc: 6980
>> > I can't see no reason its history should be mixed by something else.
>> > (More than devel historic reasons ;-)
>>
>> It makes sense to share the same history that contains only numeric
>> values between all commands that use `read-number', like
>> e.g. `goto-line' and `goto-char' (with some changes), because
>> non-numeric values (added to the history from other commands)
>> are useless for such number-reading commands.
>
> I don't have much of an opinion about the suggestion.
> There are always pros & cons to making a history more or less specific.
>
> But I'll point out that just because non-numeric histories are inappropriate for
> numeric input does not mean that the same numeric history should be used for all
> numeric inputs.
Yes, not all number-reading commands should share the numeric history.
For instance, version-control commands that read a revision number
can also accept non-numeric values like "submit:". So every case
should be carefully considered on its own.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#6980: Could goto-char please have its own history list?
2011-08-18 11:52 ` Juri Linkov
@ 2011-08-18 12:27 ` Lennart Borgman
0 siblings, 0 replies; 7+ messages in thread
From: Lennart Borgman @ 2011-08-18 12:27 UTC (permalink / raw)
To: Juri Linkov; +Cc: 6980
On Thu, Aug 18, 2011 at 13:52, Juri Linkov <juri@jurta.org> wrote:
>>> > I can't see no reason its history should be mixed by something else.
>>> > (More than devel historic reasons ;-)
>>>
>>> It makes sense to share the same history that contains only numeric
>>> values between all commands that use `read-number', like
>>> e.g. `goto-line' and `goto-char' (with some changes), because
>>> non-numeric values (added to the history from other commands)
>>> are useless for such number-reading commands.
>>
>> I don't have much of an opinion about the suggestion.
>> There are always pros & cons to making a history more or less specific.
>>
>> But I'll point out that just because non-numeric histories are inappropriate for
>> numeric input does not mean that the same numeric history should be used for all
>> numeric inputs.
>
> Yes, not all number-reading commands should share the numeric history.
>
> For instance, version-control commands that read a revision number
> can also accept non-numeric values like "submit:". So every case
> should be carefully considered on its own.
And of course I mean "I can see no reason its history should be mixed
by something else". ;-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#6980: Could goto-char please have its own history list?
2011-08-10 19:50 ` Juri Linkov
2011-08-10 21:41 ` Drew Adams
@ 2021-02-17 8:51 ` Juri Linkov
2021-07-18 20:22 ` Lars Ingebrigtsen
1 sibling, 1 reply; 7+ messages in thread
From: Juri Linkov @ 2021-02-17 8:51 UTC (permalink / raw)
To: Lennart Borgman; +Cc: 6980
>> I can't see no reason its history should be mixed by something else.
>> (More than devel historic reasons ;-)
>
> It makes sense to share the same history that contains only numeric
> values between all commands that use `read-number', like
> e.g. `goto-line' and `goto-char' (with some changes), because
> non-numeric values (added to the history from other commands)
> are useless for such number-reading commands.
Matt reminded about this request in
https://lists.gnu.org/archive/html/emacs-devel/2021-02/msg01270.html
Now `read-number' has own history in `read-number-history' added a year ago
in bug#38282. The same commit 7c5d6a2afc6 also added `goto-line-history'
for `goto-line'.
So this request could be closed unless there is still a need to add
`goto-char-history' for `goto-char' too. I'm not sure if
`read-number-history' is sufficient already, or own history should be added
to every number-reading command like `move-to-column', etc.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#6980: Could goto-char please have its own history list?
2021-02-17 8:51 ` Juri Linkov
@ 2021-07-18 20:22 ` Lars Ingebrigtsen
0 siblings, 0 replies; 7+ messages in thread
From: Lars Ingebrigtsen @ 2021-07-18 20:22 UTC (permalink / raw)
To: Juri Linkov; +Cc: Lennart Borgman, 6980
Juri Linkov <juri@jurta.org> writes:
> Now `read-number' has own history in `read-number-history' added a year ago
> in bug#38282. The same commit 7c5d6a2afc6 also added `goto-line-history'
> for `goto-line'.
>
> So this request could be closed unless there is still a need to add
> `goto-char-history' for `goto-char' too. I'm not sure if
> `read-number-history' is sufficient already, or own history should be added
> to every number-reading command like `move-to-column', etc.
I think the new number history is probably sufficient, so I'm closing
this bug report. But I wouldn't object if somebody feels strongly that
`goto-char' should have its own history.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-18 20:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-03 22:24 bug#6980: Could goto-char please have its own history list? Lennart Borgman
2011-08-10 19:50 ` Juri Linkov
2011-08-10 21:41 ` Drew Adams
2011-08-18 11:52 ` Juri Linkov
2011-08-18 12:27 ` Lennart Borgman
2021-02-17 8:51 ` Juri Linkov
2021-07-18 20:22 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).