From: Alex <agrambot@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: olaf.rogalsky@t-online.de, 29150@debbugs.gnu.org
Subject: bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode)
Date: Sun, 12 Nov 2017 18:00:57 -0600 [thread overview]
Message-ID: <878tfbdp3a.fsf@gmail.com> (raw)
In-Reply-To: <83tvxzn3tr.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Nov 2017 13:17:52 +0200")
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> Perhaps the patch should be replaced on the master branch with one that
>> uses `read-key' in all cases?
>
> Why the rush?
I don't mean to rush anything, but I figured that I should mention it
before I forget about it.
>> > Should we close this bug now, or is there anything else to do with it?
>>
>> The first issue is fixed, but not the second (`mouse-drag-secondary'
>> uses `read-event'). Here's a diff for the second:
>
> If you want this on the release branch, it should be affect only
> xt-mouse. If you propose this for master, see above.
Do you mean that I shouldn't rush the `read-key' change for
`mouse-drag-secondary' in master, either?
Would applying the previous diff for master and the following for
emacs-26 be acceptable?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: secondary2 --]
[-- Type: text/x-diff, Size: 525 bytes --]
diff --git a/lisp/mouse.el b/lisp/mouse.el
index 5eeee1ec52..b9ff71402f 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -1740,7 +1740,9 @@ mouse-drag-secondary
(let (event end end-point)
(track-mouse
(while (progn
- (setq event (read-event))
+ (setq event (if (terminal-parameter nil 'xterm-mouse-mode)
+ (read-key)
+ (read-event)))
(or (mouse-movement-p event)
(memq (car-safe event) '(switch-frame select-window))))
next prev parent reply other threads:[~2017-11-13 0:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 17:39 bug#29159: 27.0.50; Hang in HTML/CSS code Lars Ingebrigtsen
2017-11-05 19:53 ` bug#29159: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode) Olaf Rogalsky
2017-11-05 7:42 ` bug#29150: " Alex
2017-11-05 20:34 ` bug#29150: Fwd: " Olaf Rogalsky
2017-11-06 15:59 ` Eli Zaretskii
2017-11-06 21:43 ` Olaf Rogalsky
2017-11-11 9:15 ` Eli Zaretskii
2017-11-12 8:25 ` Alex
2017-11-12 11:17 ` Eli Zaretskii
2017-11-13 0:00 ` Alex [this message]
2017-11-13 15:51 ` Eli Zaretskii
2017-11-13 18:14 ` Olaf Rogalsky
2017-11-13 18:31 ` Eli Zaretskii
2017-11-13 19:09 ` Olaf Rogalsky
2017-11-12 16:30 ` Stefan Monnier
2020-08-10 16:25 ` Stefan Kangas
2021-05-10 12:14 ` bug#29150: " Lars Ingebrigtsen
2017-11-08 20:57 ` bug#29150: Fwd: " Alex
2017-11-08 21:30 ` Alex
2017-11-08 22:13 ` Stefan Monnier
2017-11-09 6:26 ` Alex
2017-11-09 8:21 ` Stefan Monnier
2017-11-09 15:47 ` Eli Zaretskii
2017-11-05 21:55 ` bug#29159: 27.0.50; Hang in HTML/CSS code Simen Heggestøyl
2017-11-12 18:50 ` Tom Tromey
2017-11-26 2:17 ` Stefan Monnier
2017-11-26 14:52 ` Simen Heggestøyl
2017-11-26 17:36 ` Tom Tromey
2017-11-25 20:49 ` bug#29159: done Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tfbdp3a.fsf@gmail.com \
--to=agrambot@gmail.com \
--cc=29150@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=olaf.rogalsky@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).