unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Olaf Rogalsky <olaf.rogalsky@t-online.de>
To: 29150@debbugs.gnu.org
Subject: bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode)
Date: Sun, 05 Nov 2017 21:34:30 +0100	[thread overview]
Message-ID: <87wp34a2i1.fsf@t-online.de> (raw)
In-Reply-To: <87zi81yxx1.fsf@gmail.com>

Hi,

in case of a button down event, `describe-key' has some trickery to also
read the forthcoming up event. The following patch makes this trickery
work with xterm-mouse-mode.

I don't have write permission to the repositiory. I therefore would
appreciate it very much, if someone else could review und submit the
patch.

PS: It would be nice, if that person also can have a look at patch #29104

PSS: I don't think, that #29143 is related. Both, `Evil-mode' *and*
     `xterm-mouse-mode' fool around with the ?\e prefix in the
     `input-decode-map', but they obviously do it in an incompatible
     way.


diff --git a/lisp/help.el b/lisp/help.el
index bc8035db0e..247f060f24 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -753,7 +753,7 @@ help-read-key-sequence
                     (and (> (length key) 1)
                          (eventp (aref key 1))
                          (memq 'down (event-modifiers (aref key 1)))))
-                (read-event))))
+                (aref (read-key-sequence-vector nil) 0))))
       ;; Put yank-menu back as it was, if we changed it.
       (when saved-yank-menu
         (setq yank-menu (copy-sequence saved-yank-menu))

-- 
Olaf Rogalsky
Schwörhausgasse 5
89073 Ulm
Germany





  reply	other threads:[~2017-11-05 20:34 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-05 17:39 bug#29159: 27.0.50; Hang in HTML/CSS code Lars Ingebrigtsen
2017-11-05 19:53 ` bug#29159: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode) Olaf Rogalsky
2017-11-05  7:42   ` bug#29150: " Alex
2017-11-05 20:34     ` Olaf Rogalsky [this message]
2017-11-06 15:59       ` bug#29150: Fwd: " Eli Zaretskii
2017-11-06 21:43         ` Olaf Rogalsky
2017-11-11  9:15           ` Eli Zaretskii
2017-11-12  8:25             ` Alex
2017-11-12 11:17               ` Eli Zaretskii
2017-11-13  0:00                 ` Alex
2017-11-13 15:51                   ` Eli Zaretskii
2017-11-13 18:14                 ` Olaf Rogalsky
2017-11-13 18:31                   ` Eli Zaretskii
2017-11-13 19:09                     ` Olaf Rogalsky
2017-11-12 16:30               ` Stefan Monnier
2020-08-10 16:25                 ` Stefan Kangas
2021-05-10 12:14               ` bug#29150: " Lars Ingebrigtsen
2017-11-08 20:57       ` bug#29150: Fwd: " Alex
2017-11-08 21:30         ` Alex
2017-11-08 22:13           ` Stefan Monnier
2017-11-09  6:26             ` Alex
2017-11-09  8:21               ` Stefan Monnier
2017-11-09 15:47               ` Eli Zaretskii
2017-11-05 21:55 ` bug#29159: 27.0.50; Hang in HTML/CSS code Simen Heggestøyl
2017-11-12 18:50   ` Tom Tromey
2017-11-26  2:17   ` Stefan Monnier
2017-11-26 14:52     ` Simen Heggestøyl
2017-11-26 17:36     ` Tom Tromey
2017-11-25 20:49 ` bug#29159: done Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp34a2i1.fsf@t-online.de \
    --to=olaf.rogalsky@t-online.de \
    --cc=29150@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).