From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.bugs Subject: bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode) Date: Sun, 12 Nov 2017 18:00:57 -0600 Message-ID: <878tfbdp3a.fsf@gmail.com> References: <87y3nka4ez.fsf@t-online.de> <87wp34a2i1.fsf@t-online.de> <83y3njs8i1.fsf@gnu.org> <878tfjnkwg.fsf@t-online.de> <834lq1p455.fsf@gnu.org> <87tvxz3nv1.fsf@gmail.com> <83tvxzn3tr.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1510531336 3129 195.159.176.226 (13 Nov 2017 00:02:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 13 Nov 2017 00:02:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: olaf.rogalsky@t-online.de, 29150@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 13 01:02:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eE2CU-0000Ew-Kk for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 Nov 2017 01:02:06 +0100 Original-Received: from localhost ([::1]:51655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eE2Ca-0000NL-IU for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 Nov 2017 19:02:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eE2CT-0000NG-C5 for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2017 19:02:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eE2CQ-0007Ka-A4 for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2017 19:02:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56924) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eE2CQ-0007KW-6N for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2017 19:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eE2CP-0004FQ-Qf for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2017 19:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Nov 2017 00:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29150-submit@debbugs.gnu.org id=B29150.151053129516297 (code B ref 29150); Mon, 13 Nov 2017 00:02:01 +0000 Original-Received: (at 29150) by debbugs.gnu.org; 13 Nov 2017 00:01:35 +0000 Original-Received: from localhost ([127.0.0.1]:37372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eE2By-0004Em-UY for submit@debbugs.gnu.org; Sun, 12 Nov 2017 19:01:35 -0500 Original-Received: from mail-io0-f175.google.com ([209.85.223.175]:52696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eE2Bx-0004EV-Fp for 29150@debbugs.gnu.org; Sun, 12 Nov 2017 19:01:34 -0500 Original-Received: by mail-io0-f175.google.com with SMTP id u42so792494ioi.9 for <29150@debbugs.gnu.org>; Sun, 12 Nov 2017 16:01:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=N7COLC/P0Vh0EhgLZd5BI94N6k6StAIRql1ZwG2McpU=; b=ExRfCza/ITk3LcWZV9ZNHKqixkfKWUUFDJRqoMM8fRrIDkQezpWdDEC+YUtxKUfQ/M buHMLA1yeLbOWBBgnAP1d8ye8Uq7/muWK1oVvWSCTAWqfZyav1E2/wzUOvE8haZal1rL jvdsm+MZAKZUjks/G0nwXLIhZdCKsl3snBHUFP5JMu/ipf6ueX1EfzMN1YC0nMBrsJB1 CozfQ800t05cTpckhG3ixerxfdqQEoYGgkT5nMcScJ2OiFKVriGFnD8TqKcSr+/wavuf uhR35prl1zPNsj1QYUvtlAZBC69U+kCTl/mJkk7vP5cfl6tqz6zgW76vHoNTDMJnfDvv xI8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=N7COLC/P0Vh0EhgLZd5BI94N6k6StAIRql1ZwG2McpU=; b=i/ORj+dmOTjHh37nKvZ6wDDyuGUyO4r0xgRRe+es9gt1I3X/CrmuY+s8XCgf4xRsIR VF91WFJ5Q2VX4dFO5yUwIlD8wnzrF+QWvOL9TOAyEvEfXYf9vbe2xuvMcnqNZpYQj6L5 gj3ZFZ+/+5pKTXrGpXXEHRR8gpIu4jhLi5/yl7O77AtfsBYDrQkEF8xulyVXoEtWaa+8 FKRpx4tWtdFOisSQpBg2Uvbmxq7f8iJuft951LOBeyizK4wnZWYAh9ABAvSfBwgP5Wa4 DEyMSYuRF8PnPBLs5ZgH5TpsCj5luau37AHbhlDVzz7PPpgbIx+VNgx1N0kBitBRbfns tW1Q== X-Gm-Message-State: AJaThX6uR/bCYrthWHTY/9qKcg/PqeP/0BvcFtYcti4a3txY2ihokkRt 8NvFGBMuqlwLoBL4DgFBvrne/g== X-Google-Smtp-Source: AGs4zMayrp9dQn+UpaePR6399BuGRGkMQdKxfFkqo1Lr5dBVDRlEIlIkrPZ7hv+QM1KZgfMnwI0h7w== X-Received: by 10.107.24.135 with SMTP id 129mr2298480ioy.79.1510531287698; Sun, 12 Nov 2017 16:01:27 -0800 (PST) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id q1sm3518344itc.9.2017.11.12.16.01.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 Nov 2017 16:01:26 -0800 (PST) In-Reply-To: <83tvxzn3tr.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Nov 2017 13:17:52 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139818 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> Perhaps the patch should be replaced on the master branch with one that >> uses `read-key' in all cases? > > Why the rush? I don't mean to rush anything, but I figured that I should mention it before I forget about it. >> > Should we close this bug now, or is there anything else to do with it? >> >> The first issue is fixed, but not the second (`mouse-drag-secondary' >> uses `read-event'). Here's a diff for the second: > > If you want this on the release branch, it should be affect only > xt-mouse. If you propose this for master, see above. Do you mean that I shouldn't rush the `read-key' change for `mouse-drag-secondary' in master, either? Would applying the previous diff for master and the following for emacs-26 be acceptable? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=secondary.diff Content-Description: secondary2 diff --git a/lisp/mouse.el b/lisp/mouse.el index 5eeee1ec52..b9ff71402f 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -1740,7 +1740,9 @@ mouse-drag-secondary (let (event end end-point) (track-mouse (while (progn - (setq event (read-event)) + (setq event (if (terminal-parameter nil 'xterm-mouse-mode) + (read-key) + (read-event))) (or (mouse-movement-p event) (memq (car-safe event) '(switch-frame select-window)))) --=-=-=--