bug#55873: 28.1; browse-url-encode-url escaped dollar symbol

bug#55873: 28.1; browse-url-encode-url escaped dollar symbol

[urugang]

(browse-url
"https://www.javadoc.io/doc/com.lightbend.akka/akka-stream-alpakka-amqp_2.13/latest/akka/stream/alpakka/amqp/javadsl/AmqpSource$.html")

It opens url
"https://www.javadoc.io/doc/com.lightbend.akka/akka-stream-alpakka-amqp_2.13/latest/akka/stream/alpakka/amqp/javadsl/AmqpSource%24.html"
which escaped dollor symbol "$" to "%24".
firefox/chrome/safari all recognize dollor symbol ("$") and escaped char ("%24")
as different things.

I found browse-url-url-encode-chars replace "$" as "%24", which is not
correct.

(defun browse-url-encode-url (url)
 (browse-url-url-encode-chars url "[\"()$ ]"))
(defun browse-url-url-encode-chars (text chars)
  (replace-regexp-in-string chars
                            (lambda (s)
                              (format "%%%X" (string-to-char s)))
                            text))

So I think we should remove escape encode of dollar symbol ("$") as below.

(defun browse-url-encode-url (url)
 (browse-url-url-encode-chars url "[\"() ]"))

bug#55873: 28.1; browse-url-encode-url escaped dollar symbol

[Lars Ingebrigtsen]

urugang <urugang@gmail.com> writes:

> So I think we should remove escape encode of dollar symbol ("$") as below.
>
> (defun browse-url-encode-url (url)
>  (browse-url-url-encode-chars url "[\"() ]"))

Yup.  I've fixed this in Emacs 29 now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no