From: urugang <urugang@gmail.com>
To: 55873@debbugs.gnu.org
Subject: bug#55873: 28.1; browse-url-encode-url escaped dollar symbol
Date: Thu, 09 Jun 2022 23:04:37 +0800 [thread overview]
Message-ID: <m1leu5yj22.fsf@urugang-macbook.mail-host-address-is-not-set> (raw)
(browse-url
"https://www.javadoc.io/doc/com.lightbend.akka/akka-stream-alpakka-amqp_2.13/latest/akka/stream/alpakka/amqp/javadsl/AmqpSource$.html")
It opens url
"https://www.javadoc.io/doc/com.lightbend.akka/akka-stream-alpakka-amqp_2.13/latest/akka/stream/alpakka/amqp/javadsl/AmqpSource%24.html"
which escaped dollor symbol "$" to "%24".
firefox/chrome/safari all recognize dollor symbol ("$") and escaped char ("%24")
as different things.
I found browse-url-url-encode-chars replace "$" as "%24", which is not
correct.
(defun browse-url-encode-url (url)
(browse-url-url-encode-chars url "[\"()$ ]"))
(defun browse-url-url-encode-chars (text chars)
(replace-regexp-in-string chars
(lambda (s)
(format "%%%X" (string-to-char s)))
text))
So I think we should remove escape encode of dollar symbol ("$") as below.
(defun browse-url-encode-url (url)
(browse-url-url-encode-chars url "[\"() ]"))
next reply other threads:[~2022-06-09 15:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 15:04 urugang [this message]
2022-06-09 15:12 ` bug#55873: 28.1; browse-url-encode-url escaped dollar symbol Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1leu5yj22.fsf@urugang-macbook.mail-host-address-is-not-set \
--to=urugang@gmail.com \
--cc=55873@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).