From: Manuel Giraud <manuel@ledu-giraud.fr>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 58028@debbugs.gnu.org
Subject: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix
Date: Fri, 23 Sep 2022 22:43:53 +0200 [thread overview]
Message-ID: <878rm9om7q.fsf@elite.giraud> (raw)
In-Reply-To: <83k05uoujl.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Sep 2022 20:43:58 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Manuel Giraud <manuel@ledu-giraud.fr>
>> Cc: 58028@debbugs.gnu.org
>> Date: Fri, 23 Sep 2022 17:59:48 +0200
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> >> From: Manuel Giraud <manuel@ledu-giraud.fr>
>> >> Date: Fri, 23 Sep 2022 17:22:07 +0200
>> >>
>> >> Maybe this problem never triggers. It is a « better be safe » kind of
>> >> patch.
>> >
>> > Please add an assertion there, to catch the case that previously was
>> > handled by testing only w->desired_matrix.
>>
>> I do not understand what you mean here.
>
> I mean the assertion that triggers when w->desired_matrix is NULL, but
> w->current_matrix isn't.
Oh I see. I add the following:
--8<---------------cut here---------------start------------->8---
eassert ((w->desired_matrix == NULL) &&
(w->current_matrix != NULL));
--8<---------------cut here---------------end--------------->8---
and test a little bit with emacs -Q and nothing break. So I think
you're right: when w->desired_matrix is NULL, both are.
--
Manuel Giraud
next prev parent reply other threads:[~2022-09-23 20:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 15:22 bug#58028: 29.0.50; Ensures no leakage of glyph_matrix Manuel Giraud
2022-09-23 15:49 ` Eli Zaretskii
2022-09-23 15:59 ` Manuel Giraud
2022-09-23 17:43 ` Eli Zaretskii
2022-09-23 20:43 ` Manuel Giraud [this message]
2022-09-24 0:26 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-24 5:46 ` Eli Zaretskii
2022-09-24 10:29 ` Manuel Giraud
2022-09-24 10:34 ` Lars Ingebrigtsen
2022-09-24 10:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-24 12:31 ` Eli Zaretskii
2022-09-24 15:31 ` Manuel Giraud
2022-09-24 16:09 ` Eli Zaretskii
2022-09-25 16:51 ` Manuel Giraud
2022-09-25 19:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rm9om7q.fsf@elite.giraud \
--to=manuel@ledu-giraud.fr \
--cc=58028@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).