From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.bugs Subject: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix Date: Fri, 23 Sep 2022 22:43:53 +0200 Message-ID: <878rm9om7q.fsf@elite.giraud> References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> <83k05uoujl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21500"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: 58028@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 23 22:44:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obpX2-0005Pr-4v for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Sep 2022 22:44:20 +0200 Original-Received: from localhost ([::1]:44598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1obpX1-0003mo-13 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Sep 2022 16:44:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obpWl-0003ma-PL for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2022 16:44:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1obpWj-0000PK-QG for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2022 16:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1obpWj-0007Pt-Kd for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2022 16:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2022 20:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58028 X-GNU-PR-Package: emacs Original-Received: via spool by 58028-submit@debbugs.gnu.org id=B58028.166396583828492 (code B ref 58028); Fri, 23 Sep 2022 20:44:01 +0000 Original-Received: (at 58028) by debbugs.gnu.org; 23 Sep 2022 20:43:58 +0000 Original-Received: from localhost ([127.0.0.1]:41850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obpWg-0007PU-ET for submit@debbugs.gnu.org; Fri, 23 Sep 2022 16:43:58 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:25933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obpWf-0007PM-2h for 58028@debbugs.gnu.org; Fri, 23 Sep 2022 16:43:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=zFDFcoQ9YGS465QO c69hO2+b/am6fBhph37d58dDmy8=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=HQKtl7F8UEoBFRARu7EQCGQ7GZ5s2T4zOsruFE ZQyCZ77hcW+bmGRFhnpGGmpJoWf5mZ0MoVOuP2P+YK1JunjGv9kZWYrwkPoQrcO2zLO19R BNXh29bV6ViEGrxE5dy2pTVj15KjbfDAvQK6UVO7A3qg5YDZEb605NtRMCqJPrHmpnMk7X mgVH4AmhLEeGCQU3+fq4q2Rbph5MWWUzHixs/sIfT8uynsc/voI1z5/Bx1aBbnIYW+/2Tz VKB/8gtKoH5FqwHd4ox398oOe3DvHPfWksJPa8bh07irmP/HRqKaCe14gs77CYpzDOMOBS K8Rkd4/rsBlYmN0r9M/BsvAQ== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id f0aefae6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 23 Sep 2022 22:43:54 +0200 (CEST) In-Reply-To: <83k05uoujl.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Sep 2022 20:43:58 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243498 Archived-At: Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: 58028@debbugs.gnu.org >> Date: Fri, 23 Sep 2022 17:59:48 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> >> From: Manuel Giraud >> >> Date: Fri, 23 Sep 2022 17:22:07 +0200 >> >>=20 >> >> Maybe this problem never triggers. It is a =C2=AB better be safe =C2= =BB kind of >> >> patch. >> > >> > Please add an assertion there, to catch the case that previously was >> > handled by testing only w->desired_matrix. >>=20 >> I do not understand what you mean here. > > I mean the assertion that triggers when w->desired_matrix is NULL, but > w->current_matrix isn't. Oh I see. I add the following: --8<---------------cut here---------------start------------->8--- eassert ((w->desired_matrix =3D=3D NULL) && (w->current_matrix !=3D NULL)); --8<---------------cut here---------------end--------------->8--- and test a little bit with emacs -Q and nothing break. So I think you're right: when w->desired_matrix is NULL, both are. --=20 Manuel Giraud