From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 58028@debbugs.gnu.org
Subject: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix
Date: Sat, 24 Sep 2022 15:31:07 +0300 [thread overview]
Message-ID: <83czblned0.fsf@gnu.org> (raw)
In-Reply-To: <874jwxnk02.fsf@elite.giraud> (message from Manuel Giraud on Sat, 24 Sep 2022 12:29:17 +0200)
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 58028@debbugs.gnu.org
> Date: Sat, 24 Sep 2022 12:29:17 +0200
>
> + eassert ((w->desired_matrix == NULL)
> + && (w->current_matrix != NULL));
> if (w->desired_matrix == NULL)
> - {
> - w->desired_matrix = new_glyph_matrix (NULL);
> - w->current_matrix = new_glyph_matrix (NULL);
> - }
> + w->desired_matrix = new_glyph_matrix (NULL);
> +
> + if (w->current_matrix == NULL)
> + w->current_matrix = new_glyph_matrix (NULL);
I think this should be
/* If matrices are not yet allocated, allocate them now. */
if (w->desired_matrix == NULL)
{
w->desired_matrix = new_glyph_matrix (NULL);
eassert (w->current_matrix == NULL);
}
if (w->current_matrix == NULL)
w->current_matrix = new_glyph_matrix (NULL);
next prev parent reply other threads:[~2022-09-24 12:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 15:22 bug#58028: 29.0.50; Ensures no leakage of glyph_matrix Manuel Giraud
2022-09-23 15:49 ` Eli Zaretskii
2022-09-23 15:59 ` Manuel Giraud
2022-09-23 17:43 ` Eli Zaretskii
2022-09-23 20:43 ` Manuel Giraud
2022-09-24 0:26 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-24 5:46 ` Eli Zaretskii
2022-09-24 10:29 ` Manuel Giraud
2022-09-24 10:34 ` Lars Ingebrigtsen
2022-09-24 10:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-24 12:31 ` Eli Zaretskii [this message]
2022-09-24 15:31 ` Manuel Giraud
2022-09-24 16:09 ` Eli Zaretskii
2022-09-25 16:51 ` Manuel Giraud
2022-09-25 19:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83czblned0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58028@debbugs.gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).