From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#61602: [PATCH]: comint-mode redirection Date: Fri, 12 May 2023 09:54:46 +0200 Message-ID: <878rdu2ddl.fsf@igel.home> References: <873573ryft.fsf@zohomail.eu> <87pm763gfy.fsf@zohomail.eu> <83ednm3v9v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30074"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: ruijie@netyu.xyz, rahguzar@zohomail.eu, eliz@gnu.org To: 61602@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 12 09:55:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pxNcS-0007am-I4 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 May 2023 09:55:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxNcG-00028f-HL; Fri, 12 May 2023 03:55:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxNcE-00028M-Lg for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 03:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxNcE-0001Qc-BL for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 03:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxNcE-00018U-70 for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 03:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2023 07:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61602 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Ruijie Yu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: Ruijie Yu , rahguzar@zohomail.eu, Eli Zaretskii , 61602@debbugs.gnu.org Original-Received: via spool by 61602-submit@debbugs.gnu.org id=B61602.16838780904263 (code B ref 61602); Fri, 12 May 2023 07:55:02 +0000 Original-Received: (at 61602) by debbugs.gnu.org; 12 May 2023 07:54:50 +0000 Original-Received: from localhost ([127.0.0.1]:53991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxNc2-00016g-2V for submit@debbugs.gnu.org; Fri, 12 May 2023 03:54:50 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:41650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxNc0-00016O-TH for 61602@debbugs.gnu.org; Fri, 12 May 2023 03:54:49 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4QHgyv3Mc0z1sBqH; Fri, 12 May 2023 09:54:47 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4QHgyv0Xnjz1qqlS; Fri, 12 May 2023 09:54:47 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ayTY7D9CvSln; Fri, 12 May 2023 09:54:46 +0200 (CEST) X-Auth-Info: 1mDJkCSzdAdFlTeFF2TEBPOiN5dQf0xdvIsBUbuV6h8Ox9t88mCCjbhVkYKWp1hE Original-Received: from igel.home (aftr-62-216-205-63.dynamic.mnet-online.de [62.216.205.63]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 12 May 2023 09:54:46 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id 205E62C1B97; Fri, 12 May 2023 09:54:46 +0200 (CEST) In-Reply-To: (Ruijie Yu via's message of "Fri, 12 May 2023 14:58:55 +0800") X-Yow: Yow! Is my fallout shelter termite proof? X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261617 Archived-At: On Mai 12 2023, Ruijie Yu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: >>> > -If NO-DISPLAY is non-nil, do not show the output buffer." >>> > +If NO-DISPLAY is non-nil, do not show the output buffer. >>> > +If FINISHED-REGEXP is non-nil it is used as `comint-redirect-finished-regexp' >>> > +instead of `comint-prompt-regexp'." >>> >>> Please clarify what "it" is. >> >> I think it's clear in this case: there's no other candidate for being >> "it" here except FINISHED-REGEXP. > > When I first read this sentence, I interpretted it as: > > If F-R is non-nil, F-R is used as `c-r-f-r'. Otherwise F-R is used > as `c-p-r'. > > I don't know. Maybe you see it differently, in which case I'm fine with > not changing it. Perhaps a better wording: FINISHED-REGEXP is used as `comint-redirect-finished-regexp'. If FINISHED-REGEXP is nil it defaults to `comint-prompt-regexp'. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."