From: npostavs@users.sourceforge.net
To: Glenn Morris <rgm@gnu.org>
Cc: Christopher Wellons <wellons@nullprogram.com>, 24494@debbugs.gnu.org
Subject: bug#24494: 24.4; Trailing comma in emacs-module.h
Date: Sat, 01 Jul 2017 16:50:55 -0400 [thread overview]
Message-ID: <877ezrlw40.fsf@users.sourceforge.net> (raw)
In-Reply-To: <g47f743hdi.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 12 Dec 2016 17:35:53 -0500")
tags 24494 fixed
close 24494 26.1
quit
Glenn Morris <rgm@gnu.org> writes:
> Christopher Wellons wrote:
>
>> Building Emacs itself now requires a C99 compiler, but this requirement
>> needn't extend to dynamic modules. Removing a trailing comma (see patch)
>> makes emacs-module.h C89/C90 compatible, allowing modules to be built
>> using older C compilers. Trailing commas weren't permitted until C99.
>
> Thanks for the report. I don't have an opinion, but some comments:
>
> 1) I think it's going to be hard for developers to remember to use
> different conventions for emacs-module.h, so C99-isms are likely to
> creep back in.
>
> 2) Are people really likely to be building Emacs modules with set-ups
> that can't build Emacs itself?
>
> 3) It seems this feature was supported by gcc since 0.9? Ie, forever?
> https://www.gnu.org/software/gcc/c99status.html
>
> Hopefully someone who does have an opinion will quickly either fix or
> wontfix this issue. :)
This has now been done in [1: 0489f2ca5a].
[1: 0489f2ca5a]: 2017-07-01 20:02:24 +0200
Improve C++98 compatibility
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0489f2ca5a01445d3abb39aea18d54257fedd5f1
next prev parent reply other threads:[~2017-07-01 20:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 15:22 bug#24494: 24.4; Trailing comma in emacs-module.h Christopher Wellons
2016-12-12 22:35 ` Glenn Morris
2017-07-01 20:50 ` npostavs [this message]
2017-07-02 15:28 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ezrlw40.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=24494@debbugs.gnu.org \
--cc=rgm@gnu.org \
--cc=wellons@nullprogram.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).