From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24494: 24.4; Trailing comma in emacs-module.h Date: Sat, 01 Jul 2017 16:50:55 -0400 Message-ID: <877ezrlw40.fsf@users.sourceforge.net> References: <87fuotnupa.fsf@wellocc1-ares.jhuapl.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1498942216 18966 195.159.176.226 (1 Jul 2017 20:50:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 1 Jul 2017 20:50:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: Christopher Wellons , 24494@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 01 22:50:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRPLG-0004aJ-Ce for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Jul 2017 22:50:10 +0200 Original-Received: from localhost ([::1]:55864 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRPLL-0003XV-RU for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Jul 2017 16:50:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRPLD-0003Te-Fy for bug-gnu-emacs@gnu.org; Sat, 01 Jul 2017 16:50:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRPL8-0005NU-L2 for bug-gnu-emacs@gnu.org; Sat, 01 Jul 2017 16:50:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dRPL8-0005NH-HE for bug-gnu-emacs@gnu.org; Sat, 01 Jul 2017 16:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dRPL8-0001Oj-BH for bug-gnu-emacs@gnu.org; Sat, 01 Jul 2017 16:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Jul 2017 20:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24494 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24494-submit@debbugs.gnu.org id=B24494.14989421685321 (code B ref 24494); Sat, 01 Jul 2017 20:50:02 +0000 Original-Received: (at 24494) by debbugs.gnu.org; 1 Jul 2017 20:49:28 +0000 Original-Received: from localhost ([127.0.0.1]:48012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRPKa-0001Ng-16 for submit@debbugs.gnu.org; Sat, 01 Jul 2017 16:49:28 -0400 Original-Received: from mail-it0-f50.google.com ([209.85.214.50]:36907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRPKY-0001NO-0m; Sat, 01 Jul 2017 16:49:26 -0400 Original-Received: by mail-it0-f50.google.com with SMTP id m84so40227045ita.0; Sat, 01 Jul 2017 13:49:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=e27WXrBS2mYj3Go+Gd53iZR8Urv4yKHq9wA6cGt3L7c=; b=mWErzY2FLE3meR6cbQBvmXmzGZ7tBlaTGXPY30qM54VtePhlgD42mFJrcL2N1v9r74 Yqm3of8duEaxUcQ+VBLplVb56Uy2gMVb8NvtoVEW809R0tvJknwB9cFIcLpShobHV7E1 r0mJdDzwKG9glqIYJnabzdltqkMw4O8xDiGcmlw6Qn2AEaRtSjGDO/WP8J+AAwSzshPo o0QZCSfEgxiFTPwVPRKCo8nGYB6Bv6feD5TSpfayx5teZfW5R+1260ievDNwtH4i+GkH wU0wl8pnb2O3AwQjn5nUdHBgBFQODabm7TqJl4vKCDKshHKcQm7dQQYdJUMqF+1VZHjP 85Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=e27WXrBS2mYj3Go+Gd53iZR8Urv4yKHq9wA6cGt3L7c=; b=GZBqvFrosh7akxCRtvqwWaYkd29ombaA/16wFT+PIdBrIZDp4hS1OFWyfcfxFLbpe9 nI2T0s3DmGx2t/yaKxSk4WrdeAD4SLeXXHjlC1rHua5KOS/Ns1r6zPph+1jzD0MzLQ/4 Jo6ag+85i02XuB22bblKVY/RIVFFQO5E3k/5VVglXCqiRzHP8xIXZ8UfMJmdEnHbGOdR v/kcHGtesMdbl3AZ7g3WEpa1MU2qAW7k4u83+l/kQ+0xVfgc1WtC1LUhcHOjdsHL2zWS Ky6Qv7QvdaWuV26p0WZxC4DvszLrZZds5NVQ7slGXnVsqC7wq5kz2moknqLDzeOj8iiO xjjg== X-Gm-Message-State: AKS2vOyKqf4gPa69qRp0EYG9zaHd7qHybCTIe7CT3LhzqeTk15uqAv2L KeDr84NZFwXjt7i6 X-Received: by 10.36.94.10 with SMTP id h10mr26223088itb.103.1498942160030; Sat, 01 Jul 2017 13:49:20 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id q70sm2069965itb.1.2017.07.01.13.49.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Jul 2017 13:49:19 -0700 (PDT) In-Reply-To: (Glenn Morris's message of "Mon, 12 Dec 2016 17:35:53 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134084 Archived-At: tags 24494 fixed close 24494 26.1 quit Glenn Morris writes: > Christopher Wellons wrote: > >> Building Emacs itself now requires a C99 compiler, but this requirement >> needn't extend to dynamic modules. Removing a trailing comma (see patch) >> makes emacs-module.h C89/C90 compatible, allowing modules to be built >> using older C compilers. Trailing commas weren't permitted until C99. > > Thanks for the report. I don't have an opinion, but some comments: > > 1) I think it's going to be hard for developers to remember to use > different conventions for emacs-module.h, so C99-isms are likely to > creep back in. > > 2) Are people really likely to be building Emacs modules with set-ups > that can't build Emacs itself? > > 3) It seems this feature was supported by gcc since 0.9? Ie, forever? > https://www.gnu.org/software/gcc/c99status.html > > Hopefully someone who does have an opinion will quickly either fix or > wontfix this issue. :) This has now been done in [1: 0489f2ca5a]. [1: 0489f2ca5a]: 2017-07-01 20:02:24 +0200 Improve C++98 compatibility http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0489f2ca5a01445d3abb39aea18d54257fedd5f1