From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 29334@debbugs.gnu.org, vianchielfaura@gmail.com
Subject: bug#29334: 25.3; compiled commands don't respect special interactive expressions
Date: Fri, 24 Nov 2017 07:17:58 -0500 [thread overview]
Message-ID: <877eufzx8p.fsf@users.sourceforge.net> (raw)
In-Reply-To: <83vai09kgq.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 24 Nov 2017 09:58:29 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> To fix this, change `call-interactively' so that it checks compiled
>> functions for lexical-binding as well. Then the byte-compiler can
>> preserve the source of interactive forms regardless of the value of
>> lexical-binding.
>
> Thanks. If no objections are voiced to this approach, please push it
> to the master branch. I think this is too radical for the release
> branch.
Hah, okay, but that was the conservative approach! The radical one
would be resolving this FIXME:
static void
fix_command (Lisp_Object input, Lisp_Object values)
{
/* FIXME: Instead of this ugly hack, we should provide a way for an
interactive spec to return an expression/function that will re-build the
args without user intervention. */
> P.S. Should this change be reflected in the ELisp manual somehow?
I don't see where.
next prev parent reply other threads:[~2017-11-24 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 6:17 bug#29334: 25.3; compiled commands don't respect special interactive expressions Allen Li
2017-11-17 14:55 ` Drew Adams
2018-01-04 5:25 ` Stefan Monnier
2017-11-21 19:45 ` Glenn Morris
2017-11-24 3:11 ` Noam Postavsky
2017-11-24 7:58 ` Eli Zaretskii
2017-11-24 12:17 ` Noam Postavsky [this message]
2018-01-04 2:56 ` Noam Postavsky
2018-01-07 2:55 ` Noam Postavsky
2022-02-10 7:56 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eufzx8p.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=29334@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=vianchielfaura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).