unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Drew Adams <drew.adams@oracle.com>
Cc: 29334@debbugs.gnu.org, Allen Li <vianchielfaura@gmail.com>
Subject: bug#29334: 25.3; compiled commands don't respect special interactive expressions
Date: Thu, 04 Jan 2018 00:25:55 -0500	[thread overview]
Message-ID: <jwv4lo2436z.fsf-monnier+bug#29334@gnu.org> (raw)
In-Reply-To: <07ace48b-93b3-4b01-9f71-b69ed44492c6@default> (Drew Adams's message of "Fri, 17 Nov 2017 06:55:41 -0800 (PST)")

> Yes, thank you!  This is something that has bugged me
> for a while.  This change is actually a regression (or
> else on purpose?), introduced in Emacs 24.

Indeed.  As for the question in parenthesis, yes I consciously decided
to break this "ugly hack" back then, wondering how much time it would
take for people to notice it (and hoping I'd find the time/motivation
to "do it right" in the mean time).

> Hah, okay, but that was the conservative approach!  The radical one
> would be resolving this FIXME:
>
>     static void
>     fix_command (Lisp_Object input, Lisp_Object values)
>     {
>       /* FIXME: Instead of this ugly hack, we should provide a way for an
>          interactive spec to return an expression/function that will re-build the
>          args without user intervention.  */

E.g. we could allow the interactive spec to return either a list of
argument *values*, or a list of argument *expressions* (and we could
distinguish the two by having the second be a vector instead of a list,
for example).


        Stefan





  reply	other threads:[~2018-01-04  5:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17  6:17 bug#29334: 25.3; compiled commands don't respect special interactive expressions Allen Li
2017-11-17 14:55 ` Drew Adams
2018-01-04  5:25   ` Stefan Monnier [this message]
2017-11-21 19:45 ` Glenn Morris
2017-11-24  3:11   ` Noam Postavsky
2017-11-24  7:58     ` Eli Zaretskii
2017-11-24 12:17       ` Noam Postavsky
2018-01-04  2:56         ` Noam Postavsky
2018-01-07  2:55           ` Noam Postavsky
2022-02-10  7:56 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='jwv4lo2436z.fsf-monnier+bug#29334@gnu.org' \
    --to=monnier@iro.umontreal.ca \
    --cc=29334@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    --cc=vianchielfaura@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).