From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29334: 25.3; compiled commands don't respect special interactive expressions Date: Fri, 24 Nov 2017 07:17:58 -0500 Message-ID: <877eufzx8p.fsf@users.sourceforge.net> References: <87efooz7z8.fsf@users.sourceforge.net> <83vai09kgq.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1511525961 10021 195.159.176.226 (24 Nov 2017 12:19:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 24 Nov 2017 12:19:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29334@debbugs.gnu.org, vianchielfaura@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 24 13:19:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eICwt-000225-CF for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Nov 2017 13:19:15 +0100 Original-Received: from localhost ([::1]:48766 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eICwx-00042N-C3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Nov 2017 07:19:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eICwl-00040Y-66 for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2017 07:19:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eICwg-000496-7l for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2017 07:19:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46095) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eICwg-00048T-3i for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2017 07:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eICwf-0001nW-SA for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2017 07:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Nov 2017 12:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29334 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29334-submit@debbugs.gnu.org id=B29334.15115258926846 (code B ref 29334); Fri, 24 Nov 2017 12:19:01 +0000 Original-Received: (at 29334) by debbugs.gnu.org; 24 Nov 2017 12:18:12 +0000 Original-Received: from localhost ([127.0.0.1]:54776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eICvp-0001mJ-J3 for submit@debbugs.gnu.org; Fri, 24 Nov 2017 07:18:09 -0500 Original-Received: from mail-io0-f176.google.com ([209.85.223.176]:36772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eICvm-0001ls-TB for 29334@debbugs.gnu.org; Fri, 24 Nov 2017 07:18:07 -0500 Original-Received: by mail-io0-f176.google.com with SMTP id 79so21842716ioi.3 for <29334@debbugs.gnu.org>; Fri, 24 Nov 2017 04:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=atew0ij7m4rzDSzMNIv0g9jie6frTL3cQWE4pujdG74=; b=KeKKcnAmKum6bZeex8zGC3mxQvJr3xd2mc7mzITTgaf7nmEl3QCQEmpKDXdOQcv/pO Bv3F62prF+1ks8LS9U08HxydId9ZVRr5xLpT4bcBUNERcoPFJWjF4qXZkIrgavkKVVar XzNFRmlm23cfjFdkRM1TxwXmPZWihkFW+eeRc3ki1xv7jg1EhIb91QnbDPf2wymcTa/g vVIxickiFPbF5Cvf+p8oEvB/2BJO4DqOO5CtOTQAeOK7vSyYGZYDPu/WWPmWoe1LcYax BoGV5dujTRrwZ4L7r5gBHXUeVllqFx4EZiE1A5H1vDyTGSpruhb6diVeOuihzJXkV9gP L23g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=atew0ij7m4rzDSzMNIv0g9jie6frTL3cQWE4pujdG74=; b=JPyKFiqMK+B2tJqGgNbXYlgark/MhnjcFJ21+3EUf7oqz9Bua5+oM2d3tW+UMuxbT6 DFbpLB9PDyXAf0akvudE52vaKs4dB4Mxw+E15Y9iWDKoGyOGrK2d1qylbobepV1XUf7Q 0DxPLpyEVxgYPUVA0XT65HHgEvpZznQNxTso0eEQ2WMJlxy5yLki2ZFgf+xKv7o0CwIt 1KtYU3gT0Epqb/zPAseJeCu6P9tz3urXWOpqKQvr+I5xJL/Zbn9F9Nf82Nb3jYhB0r7g pZ7MQ+8ZdPwlZd45HSnwpXhem7ynDSSdtW8wzS0pV/mCW5v9O4PgYYEFQaEWRy3N9CqU QHrA== X-Gm-Message-State: AJaThX5RN2kVynVqVSFyu8TTnMH8alZxKE0aqLgjmUmr95ETcReNuqJZ 2LKKHUvSx0GbY5vyL+QuxaA= X-Google-Smtp-Source: AGs4zMb5trUSgcohZGvjTp9l38DquivvoPamUcxF6IfjCwgvsEDj6H8Hs2b5uWjVdULiIaVotM7JFQ== X-Received: by 10.107.167.206 with SMTP id q197mr29223221ioe.94.1511525881287; Fri, 24 Nov 2017 04:18:01 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w139sm4358911itb.5.2017.11.24.04.17.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Nov 2017 04:17:59 -0800 (PST) In-Reply-To: <83vai09kgq.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 24 Nov 2017 09:58:29 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140300 Archived-At: Eli Zaretskii writes: >> To fix this, change `call-interactively' so that it checks compiled >> functions for lexical-binding as well. Then the byte-compiler can >> preserve the source of interactive forms regardless of the value of >> lexical-binding. > > Thanks. If no objections are voiced to this approach, please push it > to the master branch. I think this is too radical for the release > branch. Hah, okay, but that was the conservative approach! The radical one would be resolving this FIXME: static void fix_command (Lisp_Object input, Lisp_Object values) { /* FIXME: Instead of this ugly hack, we should provide a way for an interactive spec to return an expression/function that will re-build the args without user intervention. */ > P.S. Should this change be reflected in the ELisp manual somehow? I don't see where.