From: Robert Pluim <rpluim@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 32680@debbugs.gnu.org, Philipp Stephani <p.stephani2@gmail.com>
Subject: bug#32680: 27.0.50; Improve docstring and customization for 'message-signature'
Date: Tue, 11 Sep 2018 09:28:43 +0200 [thread overview]
Message-ID: <877ejsebmc.fsf@gmail.com> (raw)
In-Reply-To: <4qlg89tknn.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 10 Sep 2018 11:52:12 -0400")
Glenn Morris <rgm@gnu.org> writes:
> Robert Pluim wrote:
>
>> --- i/lisp/gnus/message.el
>> +++ w/lisp/gnus/message.el
>> @@ -1079,12 +1079,15 @@ message-indent-citation-function
>> (defcustom message-signature mail-signature
>> "String to be inserted at the end of the message buffer.
>> If t, the `message-signature-file' file will be inserted instead.
>> +If nil, no signature is inserted.
>> If a function, the result from the function will be used instead.
>> -If a form, the result from the form will be used instead."
>> - :version "23.2"
>> +If a form, the result from the form will be used instead.
>
> May as well rewrite it all to use the active voice while you are there.
>
OK. I modified 'mail-signature' as well, it didnʼt describe the nil
value.
>> +See `mail-signature' for the recommended format of a signature."
>> + :version "27.1"
>
> It's not new, and the default hasn't changed, so a version bump is not
> appropriate. It's just a doc fix.
Fixed.
2018-09-10 Robert Pluim <rpluim@gmail.com>
* lisp/gnus/message.el (message-signature): Allow nil as a
customizable value, and describe its effect.
* lisp/mail/sendmail.el (mail-signature): Describe effect of nil value.
diff --git i/lisp/gnus/message.el w/lisp/gnus/message.el
index 66356b6fda..6ecf804e9e 100644
--- i/lisp/gnus/message.el
+++ w/lisp/gnus/message.el
@@ -1078,13 +1078,16 @@ message-indent-citation-function
(defcustom message-signature mail-signature
"String to be inserted at the end of the message buffer.
-If t, the `message-signature-file' file will be inserted instead.
-If a function, the result from the function will be used instead.
-If a form, the result from the form will be used instead."
+If nil, no signature is inserted.
+If t, the `message-signature-file' file is inserted instead.
+If a function, the result from the function is used.
+If a form, the result from the form is used.
+See `mail-signature' for the recommended format of a signature."
:version "23.2"
:type '(choice string (const :tag "Contents of signature file" t)
function
- sexp)
+ sexp
+ (const :tag "None" nil))
:risky t
:link '(custom-manual "(message)Insertion Variables")
:group 'message-insertion)
diff --git i/lisp/mail/sendmail.el w/lisp/mail/sendmail.el
index 50dd81039e..af5270fbd9 100644
--- i/lisp/mail/sendmail.el
+++ w/lisp/mail/sendmail.el
@@ -370,6 +370,7 @@ mail-mode-map
;;;###autoload
(defcustom mail-signature t
"Text inserted at end of mail buffer when a message is initialized.
+If nil, no signature is inserted.
If t, it means to insert the contents of the file `mail-signature-file'.
If a string, that string is inserted.
(To make a proper signature, the string should begin with \\n\\n-- \\n,
next prev parent reply other threads:[~2018-09-11 7:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 13:12 bug#32680: 27.0.50; Improve docstring and customization for 'message-signature' Philipp Stephani
2018-09-10 14:25 ` Robert Pluim
2018-09-10 14:55 ` Eli Zaretskii
2018-09-10 15:52 ` Glenn Morris
2018-09-11 7:28 ` Robert Pluim [this message]
2018-09-13 15:31 ` Glenn Morris
2019-05-13 20:46 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ejsebmc.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=32680@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).