unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 32680@debbugs.gnu.org
Subject: bug#32680: 27.0.50; Improve docstring and customization for 'message-signature'
Date: Mon, 10 Sep 2018 16:25:21 +0200	[thread overview]
Message-ID: <87wort1lbi.fsf@gmail.com> (raw)
In-Reply-To: <wvr4lg89ijhz.fsf@a.muc.corp.google.com> (Philipp Stephani's message of "Mon, 10 Sep 2018 15:12:40 +0200")

Philipp Stephani <p.stephani2@gmail.com> writes:

> The manual states
>
>    If you change ‘message-signature’ to ‘nil’, Emacs will not insert
> your mail signature automatically.  You can insert your mail signature
> by typing ‘C-c C-w’ (‘message-insert-signature’) in the mail buffer.
> Emacs will look for your signature in the signature file.
>
> However, the docstring for message-signature doesn't state that nil is a
> possible value, and the customization choices also don't suggest nil.

We could even put this in emacs-26.

2018-09-10  Robert Pluim  <rpluim@gmail.com>

	* lisp/gnus/message.el (message-signature): Allow nil as a
	customizable value, and describe its effect. (Bug #32680)

diff --git i/lisp/gnus/message.el w/lisp/gnus/message.el
index 66356b6fda..ec2286b06d 100644
--- i/lisp/gnus/message.el
+++ w/lisp/gnus/message.el
@@ -1079,12 +1079,15 @@ message-indent-citation-function
 (defcustom message-signature mail-signature
   "String to be inserted at the end of the message buffer.
 If t, the `message-signature-file' file will be inserted instead.
+If nil, no signature is inserted.
 If a function, the result from the function will be used instead.
-If a form, the result from the form will be used instead."
-  :version "23.2"
+If a form, the result from the form will be used instead.
+See `mail-signature' for the recommended format of a signature."
+  :version "27.1"
   :type '(choice string (const :tag "Contents of signature file" t)
 		 function
-		 sexp)
+		 sexp
+                 (const :tag "None" nil))
   :risky t
   :link '(custom-manual "(message)Insertion Variables")
   :group 'message-insertion)





  reply	other threads:[~2018-09-10 14:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-10 13:12 bug#32680: 27.0.50; Improve docstring and customization for 'message-signature' Philipp Stephani
2018-09-10 14:25 ` Robert Pluim [this message]
2018-09-10 14:55   ` Eli Zaretskii
2018-09-10 15:52   ` Glenn Morris
2018-09-11  7:28     ` Robert Pluim
2018-09-13 15:31       ` Glenn Morris
2019-05-13 20:46       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wort1lbi.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=32680@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).