From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#32680: 27.0.50; Improve docstring and customization for 'message-signature' Date: Tue, 11 Sep 2018 09:28:43 +0200 Message-ID: <877ejsebmc.fsf@gmail.com> References: <87wort1lbi.fsf@gmail.com> <4qlg89tknn.fsf@fencepost.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1536650826 31067 195.159.176.226 (11 Sep 2018 07:27:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 11 Sep 2018 07:27:06 +0000 (UTC) Cc: 32680@debbugs.gnu.org, Philipp Stephani To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 11 09:27:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzd4f-0007xP-M7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Sep 2018 09:27:01 +0200 Original-Received: from localhost ([::1]:55923 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzd6m-0002j5-2p for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Sep 2018 03:29:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzd6f-0002ij-G8 for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2018 03:29:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzd6c-0001E5-Rz for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2018 03:29:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60074) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fzd6c-0001Dt-NH for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2018 03:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fzd6c-0004sL-EY for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2018 03:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Sep 2018 07:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32680 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32680-submit@debbugs.gnu.org id=B32680.153665093318723 (code B ref 32680); Tue, 11 Sep 2018 07:29:02 +0000 Original-Received: (at 32680) by debbugs.gnu.org; 11 Sep 2018 07:28:53 +0000 Original-Received: from localhost ([127.0.0.1]:36099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzd6S-0004ru-Oz for submit@debbugs.gnu.org; Tue, 11 Sep 2018 03:28:53 -0400 Original-Received: from mail-wm0-f65.google.com ([74.125.82.65]:35453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzd6R-0004ri-05 for 32680@debbugs.gnu.org; Tue, 11 Sep 2018 03:28:51 -0400 Original-Received: by mail-wm0-f65.google.com with SMTP id o18-v6so238776wmc.0 for <32680@debbugs.gnu.org>; Tue, 11 Sep 2018 00:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=20qg2kJfgHL4pv/h8lHwXO0Decn6DjJgM1UZBTw/nno=; b=KSQRP1Ez/XheLwy3NsQYZXEpabg+c0lDhZSyu6nTu/vWfVwu2hizb9ix73+N1exS88 d0UrgnTlQHV19GdKgA2pKNpcU/yPvrZxHlnj5kTDuc+8sfd6BEdQxrnfs3CLfFDOFSMI hUO127lFg6dbCYIUEXO1uqBN4H5KJ2R9RKyEnXubTdTPw5lNBV9RQfOGoXAdARYycotQ Adqe/9pKMzoEzpm4PImYxm4KEj+RA0lHk0rt1WZIFFZNxqYEwHyd+3OgQJnv2Ty2OM6b DgBjt09z0hJL4KMBJF6v58HYqrYY5Bj+y7QwTQ3Ee0R2IIsVYn0hQ48apAF2/Rl6n+5r J1Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=20qg2kJfgHL4pv/h8lHwXO0Decn6DjJgM1UZBTw/nno=; b=SlNrLBi9tWyttRr0qIPSRC9xaH5BzH3C1IEsP/2PUoI/vHw7yIx+UnOjyGp36G634S 110aPJvtLgv6ufLgJlMhBl8dbc/9fPpffprud3cGozqbFPZnhKQ8py29vx9a2P30MRIO fOJI0KOqMo1BO/T/b8pT7oLiYwgsuCGOcL6NIdmtTshn8GQzPQPHeCrRWlGoO8DGtUoT yd0au9ECXPth7m8GORCHqjfWhRMgQlBFLYXlW5h4p17Z0zeemMImSdlxshCbfVW/6zUH /+6ymzUpFp8Sjwf6O+rj4ZUImUZwT/zqUIFruakDei8WQuOY1sEUJq6HXi2N2kCk6S/l 58CQ== X-Gm-Message-State: APzg51Ay/VR5NiawDnDeg1xv3iMHtv0tdjNwg3Q5l2XYl4vVq0TVPZTP wzF1VfLHh0UrD4Zhkz2QuQ8= X-Google-Smtp-Source: ANB0VdbVhUd2yLBz2PKOK8c3ZF8R3eHabDHSOqKl7ka61nw3PY8Emc6kmbRBoLSNABZ4JP9X1SdBkw== X-Received: by 2002:a1c:1f50:: with SMTP id f77-v6mr405707wmf.52.1536650924976; Tue, 11 Sep 2018 00:28:44 -0700 (PDT) Original-Received: from rpluim-ubuntu (vav06-1-78-207-202-134.fbx.proxad.net. [78.207.202.134]) by smtp.gmail.com with ESMTPSA id k34-v6sm27317109wre.18.2018.09.11.00.28.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Sep 2018 00:28:44 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <4qlg89tknn.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 10 Sep 2018 11:52:12 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150210 Archived-At: Glenn Morris writes: > Robert Pluim wrote: > >> --- i/lisp/gnus/message.el >> +++ w/lisp/gnus/message.el >> @@ -1079,12 +1079,15 @@ message-indent-citation-function >> (defcustom message-signature mail-signature >> "String to be inserted at the end of the message buffer. >> If t, the `message-signature-file' file will be inserted instead. >> +If nil, no signature is inserted. >> If a function, the result from the function will be used instead. >> -If a form, the result from the form will be used instead." >> - :version "23.2" >> +If a form, the result from the form will be used instead. > > May as well rewrite it all to use the active voice while you are there. > OK. I modified 'mail-signature' as well, it didn=CA=BCt describe the nil value. >> +See `mail-signature' for the recommended format of a signature." >> + :version "27.1" > > It's not new, and the default hasn't changed, so a version bump is not > appropriate. It's just a doc fix. Fixed. 2018-09-10 Robert Pluim * lisp/gnus/message.el (message-signature): Allow nil as a customizable value, and describe its effect. * lisp/mail/sendmail.el (mail-signature): Describe effect of nil value. diff --git i/lisp/gnus/message.el w/lisp/gnus/message.el index 66356b6fda..6ecf804e9e 100644 --- i/lisp/gnus/message.el +++ w/lisp/gnus/message.el @@ -1078,13 +1078,16 @@ message-indent-citation-function =20 (defcustom message-signature mail-signature "String to be inserted at the end of the message buffer. -If t, the `message-signature-file' file will be inserted instead. -If a function, the result from the function will be used instead. -If a form, the result from the form will be used instead." +If nil, no signature is inserted. +If t, the `message-signature-file' file is inserted instead. +If a function, the result from the function is used. +If a form, the result from the form is used. +See `mail-signature' for the recommended format of a signature." :version "23.2" :type '(choice string (const :tag "Contents of signature file" t) function - sexp) + sexp + (const :tag "None" nil)) :risky t :link '(custom-manual "(message)Insertion Variables") :group 'message-insertion) diff --git i/lisp/mail/sendmail.el w/lisp/mail/sendmail.el index 50dd81039e..af5270fbd9 100644 --- i/lisp/mail/sendmail.el +++ w/lisp/mail/sendmail.el @@ -370,6 +370,7 @@ mail-mode-map ;;;###autoload (defcustom mail-signature t "Text inserted at end of mail buffer when a message is initialized. +If nil, no signature is inserted. If t, it means to insert the contents of the file `mail-signature-file'. If a string, that string is inserted. (To make a proper signature, the string should begin with \\n\\n-- \\n,