From: Lars Ingebrigtsen <larsi@gnus.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 40704@debbugs.gnu.org, Eric Abrahamsen <eric@ericabrahamsen.net>
Subject: bug#40704: 28.0.50; Improve and speed up (Gnus) registry saving
Date: Sun, 19 Jul 2020 17:22:08 +0200 [thread overview]
Message-ID: <877duzpm1r.fsf@gnus.org> (raw)
In-Reply-To: <87ft9ncz1y.fsf@web.de> (Michael Heerdegen's message of "Sun, 19 Jul 2020 17:19:37 +0200")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Presumably there's already code to print a hash table somewhere in
>> Emacs? That would be the other printer, since your patch adds a new
>> one.
>
> That's what the code currently already does. But: See what I wrote
> about the purpose of the patch: our saving code needs to modify how
> elements in the hash table are printed. The Lisp printer doesn't allow
> that per se. My suggested patch substitutes a very inefficient hack
> with a more efficient hack. The current code uses printing + re-reading
> AFAIR - and that on nested hash tables.
>
> I thought long about removing the need for this hack altogehter, but
> this is very complicated, if not impossible (yes, you would need to
> change the printer).
I didn't object to this new, more efficient printer -- I just pointed
out that you should add comments to both of the hash table printers that
there are (now) two of them.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-07-19 15:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 2:14 bug#40704: 28.0.50; Improve and speed up (Gnus) registry saving Michael Heerdegen
2020-04-20 4:13 ` Eric Abrahamsen
2020-04-20 23:26 ` Michael Heerdegen
2020-04-21 3:42 ` Eric Abrahamsen
2020-04-23 1:32 ` Michael Heerdegen
2020-04-23 2:36 ` Eric Abrahamsen
2020-04-29 16:11 ` Eric Abrahamsen
2020-07-19 2:16 ` Lars Ingebrigtsen
2020-07-19 14:52 ` Michael Heerdegen
2020-07-19 14:58 ` Lars Ingebrigtsen
2020-07-19 15:19 ` Michael Heerdegen
2020-07-19 15:22 ` Lars Ingebrigtsen [this message]
2020-07-19 15:23 ` Michael Heerdegen
2020-07-19 15:32 ` Lars Ingebrigtsen
2020-10-01 18:22 ` Lars Ingebrigtsen
2020-10-01 23:53 ` Michael Heerdegen
2020-10-02 1:38 ` Lars Ingebrigtsen
2022-04-17 15:21 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877duzpm1r.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=40704@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).