From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 40704@debbugs.gnu.org
Subject: bug#40704: 28.0.50; Improve and speed up (Gnus) registry saving
Date: Sun, 19 Apr 2020 21:13:45 -0700 [thread overview]
Message-ID: <87pnc2lrpi.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87a738ql1z.fsf@web.de> (Michael Heerdegen's message of "Sun, 19 Apr 2020 04:14:00 +0200")
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Hello,
>
> Saving the Gnus registry is quite slow currently. I profiled a bit and
> for now suggest to do something like in the attached patch. In detail:
>
> (1) We need to bind inhibit-modification-hooks -> t, this offers a good
> speedup (~ 4 or so).
>
> (2) Printing the registry which basically consists of huge hash tables,
> causes a lot of garbage. Most of that garbage seems to be unavoidable
> (is it created by the printing primitives?). Anyway, seems we should
> temporarily increase `gc-cons-threshold' drastically, this offers
> another speedup of 25% or so. The patch attached uses the value that
> works well for me and the size of my registry, and I bind it in
> `gnus-registry-save', because I assume other registries outside of Gnus
> can be smaller. What would be a good value of `gc-cons-threshold', or
> should it even scale with `gnus-registry-max-entries' instead of being
> constant?
>
> (3) I also decided to change `eieio-override-prin1' to print hash tables
> "by hand" from Lisp. The eieio-persistent requires to modify how
> elements in the hash tables are printed, and the current way of doing
> this (make a copy of the complete table, change the elements, prin1 and
> re-read the result) is not only hackish but also inefficient (it does
> this recursively for nested tables).
>
> Any comments on the suggested changes?
Not that it's up to me, but I'm all for putting in #1 and #3 as-is, and
adjusting #2 to scale with the number of `gnus-registry-max-entries',
with the addition of a hard ceiling.
Eric
next prev parent reply other threads:[~2020-04-20 4:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 2:14 bug#40704: 28.0.50; Improve and speed up (Gnus) registry saving Michael Heerdegen
2020-04-20 4:13 ` Eric Abrahamsen [this message]
2020-04-20 23:26 ` Michael Heerdegen
2020-04-21 3:42 ` Eric Abrahamsen
2020-04-23 1:32 ` Michael Heerdegen
2020-04-23 2:36 ` Eric Abrahamsen
2020-04-29 16:11 ` Eric Abrahamsen
2020-07-19 2:16 ` Lars Ingebrigtsen
2020-07-19 14:52 ` Michael Heerdegen
2020-07-19 14:58 ` Lars Ingebrigtsen
2020-07-19 15:19 ` Michael Heerdegen
2020-07-19 15:22 ` Lars Ingebrigtsen
2020-07-19 15:23 ` Michael Heerdegen
2020-07-19 15:32 ` Lars Ingebrigtsen
2020-10-01 18:22 ` Lars Ingebrigtsen
2020-10-01 23:53 ` Michael Heerdegen
2020-10-02 1:38 ` Lars Ingebrigtsen
2022-04-17 15:21 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnc2lrpi.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=40704@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).