From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#40704: 28.0.50; Improve and speed up (Gnus) registry saving Date: Sun, 19 Jul 2020 17:22:08 +0200 Message-ID: <877duzpm1r.fsf@gnus.org> References: <87a738ql1z.fsf@web.de> <87o8ocuu50.fsf@gnus.org> <87k0yzd0b6.fsf@web.de> <87imejpn58.fsf@gnus.org> <87ft9ncz1y.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35840"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40704@debbugs.gnu.org, Eric Abrahamsen To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 19 17:23:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxB9o-0009AM-5S for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jul 2020 17:23:16 +0200 Original-Received: from localhost ([::1]:37288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxB9n-0004vJ-8Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jul 2020 11:23:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxB9a-0004uj-RD for bug-gnu-emacs@gnu.org; Sun, 19 Jul 2020 11:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxB9a-0002S0-HT for bug-gnu-emacs@gnu.org; Sun, 19 Jul 2020 11:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxB9a-00011f-Ds for bug-gnu-emacs@gnu.org; Sun, 19 Jul 2020 11:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jul 2020 15:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40704 X-GNU-PR-Package: emacs Original-Received: via spool by 40704-submit@debbugs.gnu.org id=B40704.15951721403879 (code B ref 40704); Sun, 19 Jul 2020 15:23:02 +0000 Original-Received: (at 40704) by debbugs.gnu.org; 19 Jul 2020 15:22:20 +0000 Original-Received: from localhost ([127.0.0.1]:32776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxB8u-00010V-0d for submit@debbugs.gnu.org; Sun, 19 Jul 2020 11:22:20 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxB8s-00010I-9z for 40704@debbugs.gnu.org; Sun, 19 Jul 2020 11:22:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/wdix167tcciN4WqxTyIbkNMOCEyr7QgK+ZehinkZiw=; b=TXzaXGpj97X7V9ljLx+O/0Uq3C jFuZAZ6HK4l/0ssx3hBIXLeIce1fVGxkCI3sZ7EBrfUq1JCPUMdUbN5Ar6uc7TNm5ZYMiw5Wg16kS yCTwTPhJOg9SCMmr4YGJeNHdpof2BIZ67oVKXBmPTX+AySldX6BMLY6wlUmrVNnBOESo=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxB8j-0007Fw-TA; Sun, 19 Jul 2020 17:22:12 +0200 In-Reply-To: <87ft9ncz1y.fsf@web.de> (Michael Heerdegen's message of "Sun, 19 Jul 2020 17:19:37 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183235 Archived-At: Michael Heerdegen writes: > Lars Ingebrigtsen writes: > >> Presumably there's already code to print a hash table somewhere in >> Emacs? That would be the other printer, since your patch adds a new >> one. > > That's what the code currently already does. But: See what I wrote > about the purpose of the patch: our saving code needs to modify how > elements in the hash table are printed. The Lisp printer doesn't allow > that per se. My suggested patch substitutes a very inefficient hack > with a more efficient hack. The current code uses printing + re-reading > AFAIR - and that on nested hash tables. > > I thought long about removing the need for this hack altogehter, but > this is very complicated, if not impossible (yes, you would need to > change the printer). I didn't object to this new, more efficient printer -- I just pointed out that you should add comments to both of the hash table printers that there are (now) two of them. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no