* bug#34657: [PATCH] erc: fix erc-reuse-buffers (bug#40121)
[not found] <87lfitesdn.fsf@gmail.com>
@ 2020-08-09 10:48 ` Lars Ingebrigtsen
2020-08-10 3:34 ` Mingde (Matthew) Zeng
0 siblings, 1 reply; 2+ messages in thread
From: Lars Ingebrigtsen @ 2020-08-09 10:48 UTC (permalink / raw)
To: Mingde (Matthew) Zeng; +Cc: 34657, bandali
(Note that I've moved this from emacs-devel to the bug report.)
"Mingde (Matthew) Zeng" <matthewzmd@gmail.com> writes:
> * lisp/erc/erc.el (erc-generate-new-buffer-name): since `target' is
> always non-nil, buffer-name is non-nil, erc-reuse-buffers is t, it
> will always use the first candidate, resulting in behavior 1.
Is this correct, though?
Otherwise I think the patch looks OK, but there's unfortunately been
further changes to these functions, and your patch no longer applies.
Can you re-spin the patch?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#34657: [PATCH] erc: fix erc-reuse-buffers (bug#40121)
2020-08-09 10:48 ` bug#34657: [PATCH] erc: fix erc-reuse-buffers (bug#40121) Lars Ingebrigtsen
@ 2020-08-10 3:34 ` Mingde (Matthew) Zeng
0 siblings, 0 replies; 2+ messages in thread
From: Mingde (Matthew) Zeng @ 2020-08-10 3:34 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Mingde (Matthew) Zeng, 34657, bandali
Lars Ingebrigtsen <larsi@gnus.org> writes:
> (Note that I've moved this from emacs-devel to the bug report.)
>
> "Mingde (Matthew) Zeng" <matthewzmd@gmail.com> writes:
>
>> * lisp/erc/erc.el (erc-generate-new-buffer-name): since `target' is
>> always non-nil, buffer-name is non-nil, erc-reuse-buffers is t, it
>> will always use the first candidate, resulting in behavior 1.
>
> Is this correct, though?
Incorrect (after our previous discussion), I'll change it in my next patch.
>
> Otherwise I think the patch looks OK, but there's unfortunately been
> further changes to these functions, and your patch no longer applies.
> Can you re-spin the patch?
Sure, but in a day or two, a bit busy at the moment.
Matthew
--
Mingde (Matthew) Zeng
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-10 3:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <87lfitesdn.fsf@gmail.com>
2020-08-09 10:48 ` bug#34657: [PATCH] erc: fix erc-reuse-buffers (bug#40121) Lars Ingebrigtsen
2020-08-10 3:34 ` Mingde (Matthew) Zeng
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).