From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Mingde (Matthew) Zeng" Newsgroups: gmane.emacs.bugs Subject: bug#34657: [PATCH] erc: fix erc-reuse-buffers (bug#40121) Date: Sun, 09 Aug 2020 23:34:31 -0400 Message-ID: <877du7gomw.fsf@gmail.com> References: <87lfitesdn.fsf@gmail.com> <87k0y8umbz.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40607"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.12; emacs 27.0.91 Cc: "Mingde \(Matthew\) Zeng" , 34657@debbugs.gnu.org, bandali@gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 10 05:52:36 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4yrU-000AUd-1A for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 05:52:36 +0200 Original-Received: from localhost ([::1]:48868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4yrS-00017I-Vs for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Aug 2020 23:52:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4yqw-0000mk-3V for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 23:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4yqv-0002JZ-Qp for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 23:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4yqv-0008Uq-Ok for bug-gnu-emacs@gnu.org; Sun, 09 Aug 2020 23:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Mingde (Matthew) Zeng" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Aug 2020 03:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34657 X-GNU-PR-Package: emacs Original-Received: via spool by 34657-submit@debbugs.gnu.org id=B34657.159703149932632 (code B ref 34657); Mon, 10 Aug 2020 03:52:01 +0000 Original-Received: (at 34657) by debbugs.gnu.org; 10 Aug 2020 03:51:39 +0000 Original-Received: from localhost ([127.0.0.1]:33846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4yqX-0008UF-Sh for submit@debbugs.gnu.org; Sun, 09 Aug 2020 23:51:38 -0400 Original-Received: from mail-qk1-f193.google.com ([209.85.222.193]:33069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4ya6-00085n-QN for 34657@debbugs.gnu.org; Sun, 09 Aug 2020 23:34:39 -0400 Original-Received: by mail-qk1-f193.google.com with SMTP id p4so7208163qkf.0 for <34657@debbugs.gnu.org>; Sun, 09 Aug 2020 20:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:message-id :date:mime-version; bh=u7x2SXxgzF1GZe+8QXKHjucWdJCUDq7qnXxNUuEEyT0=; b=C5u3/KXjtb5n0vpzK7FY6aeMZsonqKBPSMWXHXv73cn3nB4FLGDRI0t+qLIn0CyXnw c7n4dDphEh1lr5QwM/uALX8zZBULWPiu3inowofpN2VYJYr0Q3SGL01CRmZEQZJzJFWU 95GwGUho2xSL7+w7PM6JOkgq2jzQkyV84N6dP48AtAQ0QBnri+ZT2mJPF9chy+7X6eT0 ykAUunpu4dQkdcujnrJUS7xdpLvtFnrQOa6BQQyEpoyiXV644fQE8Ja+0vGSYDjOd/1Y 3vm3mhwlIM5BQE4tme8bWjBy3tnbVZN0TY128kFlZMfZ5EAfwagBcwIgAV0p0wDhhFEY eVVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=u7x2SXxgzF1GZe+8QXKHjucWdJCUDq7qnXxNUuEEyT0=; b=KMtGiKgM3m51YAreaDm6w/0klc/LRTdXhw/Dxe/DYCXQiAuGJCbcirpF9YKqfK6wNf dfYQpHDYCFvDb6220h2S0UmMbD4UfV1n7Xe/KbogZOaLzK+lYQadNrWrSN8iZGc2T9UV cTYb9cMdB8G6CSKn8jBFVWa7aCYAnIGE3uItBNDVvVMkyh/HA821k6QZsPIxjwJhMX5d Gbwjp/IbKQo/CEEPvgoLixd3nPLM70pRg+vGT12DBkvHjmNpZe2oR65NoipCkq9MS0Aj eusW3IZv7HPKovD6VRRC5Qu6SRxLN787NUrDhb9ZXSr0EQlaDtgB9x4lL7GCSohRNIIl ILlg== X-Gm-Message-State: AOAM532QyjAU/8/AUiT5SBe0TF/Vj1V6K0I2kq8dBM87ZBKMH+gI0FcJ ZhHCgc8er+ErZKb9g81BekU= X-Google-Smtp-Source: ABdhPJzJFyAe5QY+8tkOwMLolhjSHA9i/jmC3gVgYzyGvEidaaK93BqWfmYYzvDDxD4MEfejrUmIzA== X-Received: by 2002:a05:620a:21cf:: with SMTP id h15mr23599269qka.123.1597030472985; Sun, 09 Aug 2020 20:34:32 -0700 (PDT) Original-Received: from mt-manjaro (216-58-109-18.cpe.distributel.net. [216.58.109.18]) by smtp.gmail.com with ESMTPSA id k11sm12276493qkk.93.2020.08.09.20.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2020 20:34:32 -0700 (PDT) In-reply-to: <87k0y8umbz.fsf@gnus.org> X-Mailman-Approved-At: Sun, 09 Aug 2020 23:51:36 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184471 Archived-At: Lars Ingebrigtsen writes: > (Note that I've moved this from emacs-devel to the bug report.) > > "Mingde (Matthew) Zeng" writes: > >> * lisp/erc/erc.el (erc-generate-new-buffer-name): since `target' is >> always non-nil, buffer-name is non-nil, erc-reuse-buffers is t, it >> will always use the first candidate, resulting in behavior 1. > > Is this correct, though? Incorrect (after our previous discussion), I'll change it in my next patch. > > Otherwise I think the patch looks OK, but there's unfortunately been > further changes to these functions, and your patch no longer applies. > Can you re-spin the patch? Sure, but in a day or two, a bit busy at the moment. Matthew -- Mingde (Matthew) Zeng