From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 7221@debbugs.gnu.org, rz.unger@web.de, Stefan Kangas <stefan@marxist.se>
Subject: bug#7221: timestamp in cvs-quickdir on Win32 system
Date: Thu, 26 Aug 2021 20:07:40 +0200 [thread overview]
Message-ID: <877dg8w043.fsf@gnus.org> (raw)
In-Reply-To: <83h7rcgbt3.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Oct 2020 13:30:16 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> I don't think I agree. My reading of the relevant CVS code is that
> CVS uses either 'asctime' or 'ctime' to produce the time string for
> "Entries", and 'asctime'/'ctime' always produce the standard format of
> the time, not the locale-preferred format produced by %c. See
> vers_ts.c:time_stamp in the CVS sources.
>
> FWIW, I see the same problem on my MS-Windows machine.
Does the proposed patch fix the issue, then? It removes the "%c" and
uses a more standard date format:
diff --git a/lisp/vc/pcvs-info.el b/lisp/vc/pcvs-info.el
index 9f8a168a0a..5a607e337b 100644
--- a/lisp/vc/pcvs-info.el
+++ b/lisp/vc/pcvs-info.el
@@ -454,7 +454,8 @@ cvs-fileinfo-from-entries
((let ((mtime (file-attribute-modification-time
(file-attributes (concat dir f))))
(system-time-locale "C"))
- (setq timestamp (format-time-string "%c" mtime t))
+ (setq timestamp (format-time-string "%a %b %e %H:%M:%S %Y"
+ mtime t))
;; Solaris sometimes uses "Wed Sep 05", not "Wed Sep 5".
;; See "grep '[^a-z_]ctime' cvs/src/*.c" for reference.
(if (= (aref timestamp 8) ?0)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-08-26 18:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 11:14 bug#7221: timestamp in cvs-quickdir on Win32 system Rolf Unger
2020-08-20 14:07 ` Lars Ingebrigtsen
2020-10-02 9:42 ` Stefan Kangas
2020-10-02 10:30 ` Eli Zaretskii
2021-08-26 18:07 ` Lars Ingebrigtsen [this message]
2021-08-26 23:06 ` Rolf Unger
2021-08-27 12:20 ` Eli Zaretskii
2021-09-25 2:38 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dg8w043.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=7221@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rz.unger@web.de \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).