unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Rolf Unger <rz.unger@web.de>
To: 7221@debbugs.gnu.org
Subject: bug#7221: timestamp in cvs-quickdir on Win32 system
Date: Fri, 15 Oct 2010 13:14:41 +0200	[thread overview]
Message-ID: <E1P6iFF-0005te-Kt@platon.wg-mit-garten.local> (raw)

I realized that the cvs-quickdir command always returned MODIFIED for the
state of the files under CVS when running this on MS Win2k. At some time
I was using cvs-quickdir on a Linux box and was suprised that the results
were correct on Linux.

I inspected this a bit closer and figured out that the problem is in the
pcvs-info.el:cvs-fileinfo-from-entries function. Comparing the file
attributes time with the timestamp from the CVS/Entries file seems to
compare two different formats.

 (setq timestamp (format-time-string "%c" mtime 'utc))

seems to be the problem. I experimented a bit with the format-time-string
and found out that the "%c" format specifier is not robust on Win32

 (insert (concat "\n" (format-time-string "%c" (current-time) t)))

gives me after:

 (setq system-time-locale nil):  15.10.2010 10:45:44

 (setq system-time-locale "C"):  10/15/10 10:44:52

The first one picks up my locale settings from the OS and is the common
german format. But only the second one is relevant for cvs-quickdir.

If I use a detailed format string "%a %b %e %H:%M:%S %Y" I get the date
string in a format that matches what is used in CVS/Entries.
I tested this on both systems Win32 (with GNU Emacs 22.3 and 23.2) and
Linux (only 22.2) ... can't say anything about Solaris, though.

For pcvs-info.el from GNU Emacs 23.2 I have

;; arch-tag: d85dde07-bdc2-400a-882f-92f398c7b0ba

at the end of the file. Can't find a cvs-version variable, though?

Rolf





             reply	other threads:[~2010-10-15 11:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-15 11:14 Rolf Unger [this message]
2020-08-20 14:07 ` bug#7221: timestamp in cvs-quickdir on Win32 system Lars Ingebrigtsen
2020-10-02  9:42   ` Stefan Kangas
2020-10-02 10:30     ` Eli Zaretskii
2021-08-26 18:07       ` Lars Ingebrigtsen
2021-08-26 23:06         ` Rolf Unger
2021-08-27 12:20           ` Eli Zaretskii
2021-09-25  2:38             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1P6iFF-0005te-Kt@platon.wg-mit-garten.local \
    --to=rz.unger@web.de \
    --cc=7221@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).